Refactor reauthentication required functionality from subclass to module#8031
Merged
mitchellhenke merged 3 commits intomainfrom Mar 21, 2023
Merged
Conversation
changelog: Internal, Authentication, Refactor reauthentication required functionality from subclass to module
mitchellhenke
force-pushed
the
mitchellhenke/reauthentication-refactored
branch
from
21b52ef to
466d8b1
Compare
aduth
reviewed
Mar 20, 2023
spec/controllers/concerns/reauthentication_required_concern_spec.rb
Outdated
Show resolved
Hide resolved
| @@ -1,9 +1,12 @@ | |||
| module Users | |||
| class EmailsController < ReauthnRequiredController | |||
Contributor
There was a problem hiding this comment.
I don't see the controller implementation removed from code. Should it be?
Contributor
Author
There was a problem hiding this comment.
whoops, yep, thank you
mitchellhenke
force-pushed
the
mitchellhenke/reauthentication-refactored
branch
from
781f89d to
09b6d0e
Compare
zachmargolis
approved these changes
Mar 20, 2023
|
|
||
| before_action :confirm_two_factor_authenticated | ||
| before_action :prompt_for_password_if_pii_locked | ||
| before_action :confirm_recently_authenticated |
Contributor
There was a problem hiding this comment.
thank you for doing these as explicit includes instead of included do ... magic!
spec/controllers/concerns/reauthentication_required_concern_spec.rb
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
We have some upcoming changes around how to handle reauthentication for accounts, and this is a slight refactor to make it a module with a method that can be called rather than a subclass that automatically calls the internal method.
This should not result in a change in behavior.