Merged
Conversation
**Why**: avoids mysterious segfaults on arm machines changelog: Internal, Development, Skip loading yard gem by default
* create fraud rejection daily job fraud_rejection_daily_job checks for profiles that have been in fraud review for 30 days and then automatically rejects them * add test for fraud rejection job * added fraud job to cron job * added ability to notify user * add changelog changelog: Internal, IdV Fraud, Automatically reject profiles after 30 days fraud review * fix typo in notify * add Fraud infront of analytics event * add index to fraud_review_pending
* Remove unused personal key JavaScript behavior changelog: Internal, Code Quality, Remove unused code * Update yarn.lock
* Include parsed phone country code in reCAPTCHA logging changelog: Upcoming Features, Fraud Mitigation, Implement spam protection for phone registration * Qualify country code in reCAPTCHA result as from phone * Avoid nil hash splatting
* Removing phone from barcode pages and search pages * Undo JS refactor * Remove phone field expectation from presenter spec * Removing phone from proofer, spec and facilities config. * Update mailer spec to remove phone * changelog: User-facing Improvements, In-person proofing, remove phone number from PO locations * remove unused translation keys * undo mock change
…USPS submission (#7938) * LG-7832: Validate State ID and Address are transliterable to a valid USPS submission changelog: Improvements, In-Person Proofing, Validate State ID and Address are transliterable to a valid USPS submission Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * LG-7832: Make test updates based on PR feedback * Update spec/services/usps_in_person_proofing/enrollment_helper_spec.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update app/services/usps_in_person_proofing/enrollment_helper.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * LG-7832: Remove incorrect usage of .class * LG-7832: Feature should only be enabled by default in dev environments * Update app/services/idv/steps/in_person/address_step.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update app/services/idv/steps/in_person/state_id_step.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * LG-7832: Use case no longer requires support for HashWithIndifferentAccess * LG-7832: Clean up translation usage * LG-7832: Update test * LG-7832: Update test * LG-7832: Simplify unsupported character extraction from transliterated string * LG-7832: Clarify transliteration result documentation * LG-7832: Refactor helper logic into validator classes * Switch to ->() lambda syntax to remove extra parens * Change one more proc syntax to "stabby lambda" * un-stub the TransliterableValidator spec as much as possible - Real ActiveModel::Errors instance - Model fields all defined in one spot - spy on real validator.transliterator instead of stubbing --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov>
Puerto Rico residents have a very low success rate with Lexisnexis Instant Verify. It appears that it expects the Urbanization part of the address to be on line 2. To gather data and take a first step toward helping Puerto Rico residents complete identity verification successfully, add guidance on how to edit their address. changelog: User-facing Improvements, Identity Verification, Add guidance on how to edit Puerto Rico addresses for improved IdV success * Change address entry field labels and fix newline in alert msg * Show guidance only if state is PR, not if issuer is PR * Add AddressPresenter to conditionally show edit field hints * New address for Puerto Rico yml fixture * Change AddressPresenter to take @pii * Update banner text per discussion with Princess * Replace a few explicit strings in specs with I18n.t lookups * Make hint strings more readable
changelog: Internal, Database, Add primary database socket configuration
* LG-8894: Describe personal key example for assistive technology changelog: User-Facing Improvements, Accessibility, Improve personal key example description for assistive technology * Update personal key specs to test for code example
* Reduce to using one primary Redis connection pool changelog: Internal, Redis, Use one primary Redis connection pool * Update app/services/out_of_band_session_accessor.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * fix spec * update gem tag version --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* LG-7832: Support multiple characters returned from transliteration; add testing around treatment of spaces * [skip changelog]
changelog: Internal, Redis, Add configuration for IRS Attempts API Redis pool size
zachmargolis
force-pushed
the
stages/rc-2023-03-14
branch
from
a561529 to
baafe05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal
Upcoming Features