Skip to content

LG-7832: Support multiple characters for USPS transliteration#7969

Merged
NavaTim merged 0 commit intomainfrom
tbradley/lg-7832-transliteration-multichar-and-spacing
Mar 10, 2023
Merged

LG-7832: Support multiple characters for USPS transliteration#7969
NavaTim merged 0 commit intomainfrom
tbradley/lg-7832-transliteration-multichar-and-spacing

Conversation

@NavaTim
Copy link
Contributor

@NavaTim NavaTim commented Mar 10, 2023

🎫 Ticket

🛠 Summary of changes

  • Support multiple characters to be returned from transliteration
  • Test behavior around non-ASCII spaces

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Complete IdV flow up to in-person state ID page
  • Enter a character that converts to multiple characters into a name field (see mappings here)
  • Enter an unsupported character (e.g. Cyrillic) into the same name field after that character
  • Complete remainder of form
  • Submit form
  • Verify that form response identifies the unsupported character correctly

@NavaTim NavaTim changed the title LG-7832: Support multiple characters returned from transliteration; a… LG-7832: Support multiple characters for USPS transliteration Mar 10, 2023
@NavaTim NavaTim requested a review from tomas-nava March 10, 2023 19:16
Copy link
Contributor

@tomas-nava tomas-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve!

before:
before

after:
after

I would recommend that you also edit line 88 in UspsInPersonProofing::TransliterableValidator to be

      (result.unsupported_chars + additional_chars).compact.sort.uniq

(adding .compact); I think your changes in this PR preclude this happening again, but I got a comparison of String with nil failed error on this line when creating the before screenshot above.

@NavaTim
Copy link
Contributor Author

NavaTim commented Mar 10, 2023

@tomas-nava Yes, the original issue was the cause of the nil value. This will prevent the nil from recurring.

@NavaTim NavaTim merged this pull request into main Mar 10, 2023
@NavaTim NavaTim deleted the tbradley/lg-7832-transliteration-multichar-and-spacing branch March 10, 2023 23:22
mitchellhenke pushed a commit that referenced this pull request Mar 14, 2023
* LG-7832: Support multiple characters returned from transliteration; add testing around treatment of spaces

* [skip changelog]
zachmargolis pushed a commit that referenced this pull request Mar 14, 2023
* LG-7832: Support multiple characters returned from transliteration; add testing around treatment of spaces

* [skip changelog]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants