Conversation
tomas-nava
approved these changes
Mar 10, 2023
Contributor
There was a problem hiding this comment.
approve!
I would recommend that you also edit line 88 in UspsInPersonProofing::TransliterableValidator to be
(result.unsupported_chars + additional_chars).compact.sort.uniq(adding .compact); I think your changes in this PR preclude this happening again, but I got a comparison of String with nil failed error on this line when creating the before screenshot above.
Contributor
Author
|
@tomas-nava Yes, the original issue was the cause of the |
mitchellhenke
pushed a commit
that referenced
this pull request
Mar 14, 2023
* LG-7832: Support multiple characters returned from transliteration; add testing around treatment of spaces * [skip changelog]
zachmargolis
pushed a commit
that referenced
this pull request
Mar 14, 2023
* LG-7832: Support multiple characters returned from transliteration; add testing around treatment of spaces * [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


🎫 Ticket
🛠 Summary of changes
📜 Testing Plan
Provide a checklist of steps to confirm the changes.