Skip to content

Include parsed phone country code in reCAPTCHA logging#7952

Merged
aduth merged 3 commits intomainfrom
aduth-recaptcha-country-code
Mar 10, 2023
Merged

Include parsed phone country code in reCAPTCHA logging#7952
aduth merged 3 commits intomainfrom
aduth-recaptcha-country-code

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Mar 9, 2023

🛠 Summary of changes

Adds parsed phone country code to event logging detail for reCAPTCHA phone validation, so that we can do regional analysis of scores.

📜 Testing Plan

  1. Add a phone to a new or existing account, using an international phone number (e.g. 3065550100)
  2. Look at recent logs with tail -n10 log/events.log | jq .

Observe: 'reCAPTCHA verify result received' event includes country_code value corresponding to international phone number.

aduth added 2 commits March 9, 2023 08:53
changelog: Upcoming Features, Fraud Mitigation, Implement spam protection for phone registration
@aduth aduth requested a review from a team March 9, 2023 13:58
Copy link
Contributor

@jmdembe jmdembe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@aduth aduth merged commit e10b263 into main Mar 10, 2023
@aduth aduth deleted the aduth-recaptcha-country-code branch March 10, 2023 13:20
zachmargolis pushed a commit that referenced this pull request Mar 14, 2023
* Include parsed phone country code in reCAPTCHA logging

changelog: Upcoming Features, Fraud Mitigation, Implement spam protection for phone registration

* Qualify country code in reCAPTCHA result as from phone

* Avoid nil hash splatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants