Reduce to using one primary Redis connection pool#7968
Merged
mitchellhenke merged 0 commit intomainfrom Mar 10, 2023
Merged
Conversation
Gemfile
Outdated
| gem 'redis', '>= 3.2.0' | ||
| gem 'redis-namespace' | ||
| gem 'redis-session-store', '>= 0.11.4' | ||
| gem 'redis-session-store', github: '18F/redis-session-store', branch: 'margolis-use-connection-pool' |
Contributor
There was a problem hiding this comment.
we'll tag a version before merging this right? 😬
Contributor
Author
There was a problem hiding this comment.
yep, the other PR isn't merged so hasn't been tagged yet
Merged
mitchellhenke
pushed a commit
that referenced
this pull request
Mar 14, 2023
* Reduce to using one primary Redis connection pool changelog: Internal, Redis, Use one primary Redis connection pool * Update app/services/out_of_band_session_accessor.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * fix spec * update gem tag version --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
zachmargolis
added a commit
that referenced
this pull request
Mar 14, 2023
* Reduce to using one primary Redis connection pool changelog: Internal, Redis, Use one primary Redis connection pool * Update app/services/out_of_band_session_accessor.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * fix spec * update gem tag version --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
To reduce the total number of connections opened to the primary Redis instance, this PR pulls in the recently resurrected
client_poolpull request in our fork of redis-session-store.The intersection of using the new
client_pooland usingREDIS_POOLeverywhere for the primary instance means dropping the use ofredis-namespace. We may want to consider moving away from the gem long-term anyway as I have an open pull request to add unsupported commands to the gem that I'd like to use elsewhere in our codebase.