Merged
Conversation
…-9150) changelog: Internal, Logging, Add regression spec for IDV funnel database logs
changelog: Internal, Logging, log ssn step views
zachmargolis
approved these changes
Mar 9, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! glad the fix was so quick here!
Contributor
Author
|
Thanks for calling it out! And adding the test to catch these in the future. |
soniaconnolly
added a commit
that referenced
this pull request
Mar 9, 2023
* Add missing DocAuthLog ssn_view_count update to SsnController#show * Add a regression spec to ensure reports log each step of IDV flow (LG-9150) changelog: Internal, Logging, Add regression spec for IDV funnel database logs and log ssn step views --------- Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov> (cherry picked from commit 0e51dac)
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9150
🛠 Summary of changes
Log ssn_view_count from SsnController#show.
Pull in @zachmargolis's additional analytics spec to catch log omissions in the future.