Merged
Conversation
…mails (#7805) * Account for polling delays when sending emails changelog: User-facing Improvements, In-person proofing, reduce delay when sending proofing emails to users if their enrollment hasn't been updated in a while * Re-run migration to get comment * Add JSON merge helper method * Update how we convert to UTC timezone * Use UTC offset instead of string name * Minor cleanups * Add check for wait_until attribute * Add spec checking queue and wait_until on failure
…ests (#7910) * Skip redundant delete and save of service provider authorization requests changelog: Internal, Service Provider Authorization Requests, Skip redundant delete and save of authorization requests * Update app/services/service_provider_request_handler.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Read Address Line 2 from Acuant responses changelog: User-Facing Improvements, Identity verification, Ensure that second line of address is read from identity documents * Log address_line2_present to Acuant * Guard against nil .Fields on PII (Was breaking a test) * Update DocumentProofingJob spec * Refactor fixture twiddling to use .tap * Add `Fields` to some acuant tests Changes to `GetResultsResponse` mean that we now attempt to read `Fields` on initialization, so we need `Fields` in our test data.
* LG-8861: Sort facilities distance in asc order * LG-8861: Create unordered distance mock data * LG-8861: Test to sort unordered facilities * changelog: User-Facing Improvements, In-person proofing, Sorts facilities by ascending distance (users address to post office) * LG-8861: Fix lint issues * LG-8861 Remove dups bef sort, use each_cons in test * LG-8861 fix spelling error
* Add GOOD_SSN_MASKED constant And take out some indirection in verify_info_step_spec feature spec. [skip changelog] --------- Co-authored-by: Luis H. Matos <ThatSpaceGuy@users.noreply.github.com>
* Move and modify alert banner * Capture formatted phone in send link step and return it in form response * Store phone in idv session instead of form response * [skip changelog] * Pass phone value for view * Store raw phone and display in link sent step * Hyphenate * Revert phone extrapolation * Remove empty line * Return correct value * Add translations * Size image element and remove enclosing p element around message * Increase bottom margin of alert * Use correct margin bottom class * Use correct Spanish character * Delete phone.png * Pushing failing test (do not merge) * Fix formatting * Replace phone icon in upload form * Consolidate multi-line calls * Updating spec and test helpers to check for combined upload flag * Updating combined upload step feature flag context test -- What This is relevant to the link_sent step tests * Store phone in session for upload step * Fix style * Store phone in session outside of phone getters --------- Co-authored-by: eric-gade <eric.gade@@gsa.gov>
* changelog: Bug Fixes, Authentication, don't allow users to submit without nickname for security key * rubocop * fix spec for webauthn * update javascript to be on form submit * erb lint fix * fix up javascript * on javascript submit the form without prompting for javascript * fix indentation
* LG-8215 Update Event: IDV Reproof - logs two events changelog: Internal, Attempts API, Fixes in tracking event
… consent happening if you don't agree. (#7896) * changelog: User-Facing Improvements, Authentication, add cancel link to completion screen * add cancel link * add cancel link * shows html * update styling for form
* Add IPP CTA variant bucket information to log events: IPP CTA displayed, ipp option clicked, ipp location visited and submitted, and ipp ready to verify visited * Introduce AB bucket mocking to ensure determinism during automated tests * changelog: Internal, In-person proofing, Include IPP CTA A/B test information in select logs to facilitate variant analysis --------- Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov>
This lets the user split their address into two lines if needed, e.g. with Puerto Rico urbanizations. changelog: User-Facing Improvements, Identity verification, On Verify Info page always show Address Line 2 field
And set :address_line2_present to true or false under 'IdV: doc auth image upload vendor submitted' analytics event changelog: User-Facing Improvements, Identity verification, Ensure that second line of address is read from identity documents (TrueID)
mitchellhenke
approved these changes
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal