Merged
Conversation
…ed, ipp option clicked, ipp location visited
… in select logs to facilitate variant analysis
NavaTim
reviewed
Feb 10, 2023
…ec to reflect variant data included in location submit log events.
…it event metadata into location step components
…fix linting of location submit changes
…e selected location
…tion submit log events
…and update expected log data for bucket-informed IPP events
svalexander
reviewed
Feb 23, 2023
...vascript/packages/document-capture/components/in-person-location-post-office-search-step.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/in-person-location-step.tsx
Outdated
Show resolved
Hide resolved
…attern for extra analytics attributes
9ffd6e6 to
90be58d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8754
🛠 Summary of changes
AB test bucket data is now included in the
event_propertiesof the following log events:📜 Testing Plan
Proceed through the IPP flow with IPP CTA variant testing enabled and confirm that variant data is present in the
event_propertiesof each of the above events, and that the supplied variant data is consistent with the IPP CTA that is shown to the user when they first fail doc auth. Special cases:👀 Screenshots
Samples of each of the 5 log events before and after these changes