Skip redundant delete and save of service provider authorization requests#7910
Merged
mitchellhenke merged 2 commits intomainfrom Mar 1, 2023
Merged
Skip redundant delete and save of service provider authorization requests#7910mitchellhenke merged 2 commits intomainfrom
mitchellhenke merged 2 commits intomainfrom
Conversation
…ests changelog: Internal, Service Provider Authorization Requests, Skip redundant delete and save of authorization requests
mitchellhenke
commented
Mar 1, 2023
| end | ||
|
|
||
| def call | ||
| return if sp_url_stored_in_session == url |
Contributor
Author
zachmargolis
reviewed
Mar 1, 2023
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Currently we read, delete, and re-write Service Provider requests, but in my testing so far it seems redundant. The values are based on parsing the request URL, so we should be able to skip the delete and re-write if they are the same since we'd be deleting and re-writing with the same data.
There is more invasive work that we probably could do around being more precise around when we need to save to Redis and using the session as the primary store for SP requests.