Skip to content

LG-8762: add cancel link to completion screen, redirect to SP without consent happening if you don't agree. #7896

Merged
mdiarra3 merged 5 commits intomainfrom
LG-8762-add-cancel-link-to-consent-screen
Mar 2, 2023
Merged

LG-8762: add cancel link to completion screen, redirect to SP without consent happening if you don't agree. #7896
mdiarra3 merged 5 commits intomainfrom
LG-8762-add-cancel-link-to-consent-screen

Conversation

@mdiarra3
Copy link
Contributor

No description provided.

@mdiarra3
Copy link
Contributor Author

Going to look into adding tests, but wondering if randomly taking them back to the SP initial URL might cause confusion for users?

@aduth
Copy link
Contributor

aduth commented Feb 27, 2023

Going to look into adding tests, but wondering if randomly taking them back to the SP initial URL might cause confusion for users?

At least in the case of OIDC, we're including an "access denied" reason as a parameter in the redirect, with the expectation that a partner would detect this to tailor messaging around not completing the sign up process, so ideally it would not be as confusing for the user vs. if we were to take them back to the partner's homepage. I think the SAML "return to SP" URL is meant to work the same, though not 100% certain. In any case, we should be generally comfortable that our implementation of return_to_sp_url would be where we expect the user to go after choosing not to complete the process.

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mdiarra3 mdiarra3 merged commit d6202f1 into main Mar 2, 2023
@mdiarra3 mdiarra3 deleted the LG-8762-add-cancel-link-to-consent-screen branch March 2, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants