Conversation
changelog: User-facing Improvements, In-person proofing, reduce delay when sending proofing emails to users if their enrollment hasn't been updated in a while
sheldon-b
commented
Feb 10, 2023
Comment on lines
+234
to
+238
| send_failed_email(enrollment.user, enrollment) | ||
| analytics(user: enrollment.user).idv_in_person_usps_proofing_results_job_email_initiated( | ||
| **email_analytics_attributes(enrollment), | ||
| email_type: 'Failed unsupported ID type', | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
ℹ️ We weren't previously sending emails when a user failed to proof due to an unsupported type of ID
sheldon-b
commented
Feb 10, 2023
added 4 commits
February 10, 2023 13:25
sheldon-b
commented
Feb 14, 2023
Comment on lines
+39
to
+40
| transaction_end_date_time: anything, | ||
| transaction_start_date_time: anything, |
Contributor
Author
There was a problem hiding this comment.
These are verified below in specific tests since not all tests will set these values (eg expired enrollments)
NavaTim
reviewed
Feb 16, 2023
added 3 commits
February 22, 2023 09:19
NavaTim
approved these changes
Feb 22, 2023
…rson-proofing-results-emails-sooner
Contributor
Author
|
I tested this change in the Joy sandbox. I created a new enrollment, asked USPS to set the enrollment to passed. I was able to confirm that the enrollment was set to passed at 13:16:19, the polling job ran at 13:30, and the email was sent at 14:16:19. That's with a 1 hour delay configured |
…rson-proofing-results-emails-sooner
sheldon-b
deleted the
sbachstein/send-in-person-proofing-results-emails-sooner
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8856
🛠 Summary of changes
proofed_attimestamp to enrollments. When an enrollment succeeds or fails we will set this timestamp based on the transaction timestamp retrieved from USPSchangelog: User-facing Improvements, In-person proofing, reduce delay when sending proofing emails to users if their enrollment hasn't been updated in a while