Merged
Conversation
* avoid first SP query * skip re-parsing and validating OIDC parameters changelog: Internal, Performance, Improve performance of OpenID Connect and SAML Auth requests
… addresses (#7698) * changelog: Internal, In-Person Proofing, Use unique responses with Faker in PO Search developer mode * Update app/services/arcgis_api/mock/fixtures.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Drop unused JSON files * Leverage USPS Proofer mock for requesting pilot facilities * Assert for location keys; further mirror irl types * Proofer mock now correctly structures pilot facilities stub --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
…7726) * Begin returning 422 for expected usps failures Still needs some work on the error responses when there are unexpected USPS failures * Annotate which requests are expected * Remove todo comment changelog: Internal, In-person proofing, stop trigger on-call paging for expected usps facilities failures
* changelog: User-facing improvements, In-person proofing, fix pluralization of search results * Changing getByText to findByText * Removing unneeded getByText * Tests using i18n context provider and now passing
…/50 IPP-enabled variants (#7724)
We recently moved this out of the flow state machine and missed this event. This commit adds it. [skip changelog]
Resolves LG-8794 changelog: Internal, Reporting, Add phone submit step to dropoff report
* AAMVA: Check for http errors before parsing SOAP If we get a non-200 back from AAMVA with a non-XML body, this would blow up. changelog: Bug Fixes, Doc auth, Handle non-200 responses from AAMVA * Add regression specs for AAMVA xml parsing * Fix auth token response spec (It raises a different kind of error) * Also fix SecurityTokenResponse spec
…to simplify test setup (#7737)
- Improve build performance - Reduce rendered page size changelog: Internal, Performance, Reduce size of rendered page
…eue alarm (#7738) * LG-8739: Change the mail queue used for delayed emails coming from the USPS proofing job * [skip changelog]
changelog: Internal, Attempts API, Account reset cancel request event
…ion screen due to screen being shown early in some cases
* display try again message when ArcGIS API errs or times out * changelog: Improvements, In-person proofing, display try again error when ArcGIS API errs * refactor address search controller
* use streetAddress instead of name * update test so selected_location is address * string update * changelog: User-Facing Improvements, Prepare page aler, update alert on prepare page to include selections address instead of name * update to include formattedcitystatezip * lint fix * analytics spec in progress * location step uses name * refactor
zachmargolis
requested review from
NavaTim,
aduth,
allthesignals,
eileen-nava,
jmhooper,
mitchellhenke,
olatifflexion,
orenyk,
sheldon-b and
svalexander
mitchellhenke
approved these changes
Feb 1, 2023
NavaTim
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal