LG-8509: update selected location alert to include address

[svalexander]

🎫 Ticket

Lg-8509

🛠 Summary of changes

SelectedLocation is updated to include the po address instead of the po name.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• Make sure arcgisSearchEnabled is true
• Navigate to search using failing id
• Select a location by clicking a select button
• Verify that the alert displays the po address

👀 Screenshots

en:

es:

fr:

[allthesignals]

Just making sure: is this all we need (not the full address)? I believe this will only include 100 main and not 100 main, city, state etc.

[svalexander]

you're right, i'll add in the additional items

[allthesignals]

Interesting... was there some code that preferred "address" to "name" somewhere?

[svalexander]

the selected_location value should now be the address as that's what the alert will now expect

[allthesignals]

I see... so the analytics thing is dropping stringified text in there for us to assert against?

[svalexander]

the metadata, yes

[allthesignals]

So, I think this looks good, but I was confused why we're still modifying in-person-location-step. Then I realized the test was probably handing data to a view that expected something else.

So, I think the real fix is to update the test (finally) to use the po search path, which we should do asap anyway...

I'll make a ticket, but maintaining both components is becoming a hassle

[aduth]

I had trouble testing this locally (more related to address search generally than these specific changes, I think), but LGTM from looking at the code 👍

[aduth]

Would it allow some simplifying to concatenate the string once and use that as the value in InPersonPrepareStep ?

Suggested change

	setSubmitEventMetadata({ selected_location: `${streetAddress}, ${formattedCityStateZip}` });
	onChange({ streetAddress, formattedCityStateZip });
	const selectedLocationAddress = `${streetAddress}, ${formattedCityStateZip}`;
	setSubmitEventMetadata({ selected_location: selectedLocationAddress });
	onChange({ selectedLocationAddress });