LG-8399: IPP PO Search: Mock ArcGIS service generates fake but unique addresses

[allthesignals]

🎫 Ticket

Link to the relevant ticket.

🛠 Summary of changes

Leverages Faker to get the ArcGIS mock service to return unique responses across requests. This reduces the severity of this bug as for as "DX" goes.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• A developer running the app locally can search multiple times when the mock service is enabled (arcgis_mock_fallback: true)

[allthesignals]

Fixtures class, which are used for the development environment mock service, now leverages this gem, and so is moved out of the :test block.

[aduth]

LGTM

[aduth]

May be cleaner to move all the methods into class << self ?

i.e.

module ArcgisApi
  module Mock
    module Fixtures
      class << self
        def request_suggestions_response
          # ...
        end

        # ...

        private

        def generate_suggestions(count = 5)
          # ...
        end
      end
    end
  end
end

[zachmargolis]

Alternatively, add a newline?

Suggested change

	private_class_method def self.generate_suggestions(count = 5)
	private_class_method
	def self.generate_suggestions(count = 5)

[allthesignals]

Hmm there is a mix of styles to doing this in the source code. I opted for:

private_class_method :generate_suggestions, :generate_address_candidates

🤷 not particularly sold on any one style.

[allthesignals]

Some updates about this:

• Need to implement feedback and suggestions
• Because we merged LG-8582: Implementation of temp 500 error on PO search #7695, which no longer throws pilots on error, we need to swap in mock Proofer (USPS) in order to fix local development

[allthesignals]

I wish I could move this above the methods (similar to Rails hooks), but it doesn't seem to know about the methods then.