Merged
Conversation
ffe207b to
e8d23cb
Compare
e8d23cb to
736d1e8
Compare
changelog: User-Facing Improvements, sms expiration timer, redirect to sms expired
71240d8 to
ce0fe9f
Compare
9ea0f27 to
a7749ec
Compare
6ab6f1c to
18a436a
Compare
18a436a to
2b1920a
Compare
aduth
reviewed
Jan 26, 2023
spec/controllers/two_factor_authentication/otp_expired_controller_spec.rb
Outdated
Show resolved
Hide resolved
app/controllers/two_factor_authentication/otp_expired_controller.rb
Outdated
Show resolved
Hide resolved
…ler_spec.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
…er.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
edbfb90 to
d34fa58
Compare
d34fa58 to
5754cad
Compare
aduth
approved these changes
Jan 26, 2023
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
b6c5c1b to
47831aa
Compare
Merged
aduth
added a commit
that referenced
this pull request
Feb 1, 2023
This reverts commit 2e5a156. changelog: Bug Fixes, Multi-Factor Authentication, Revert OTP expiration screen due to screen being shown early in some cases
aduth
added a commit
that referenced
this pull request
Feb 1, 2023
zachmargolis
added a commit
that referenced
this pull request
Feb 1, 2023
This reverts commit 2e5a156.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8336
🛠 Summary of changes
This ticket completes the implementation of the the timer that counts down to when the one-time password expires. Now, we redirect to a page that informs users that their code has expired and to request a new one.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
Before testing
otp_valid_for: 3toapplication.ymlto speed up testingotp_valid_forvalueOptional: Repeat testing on add phone setup and one time code verification setup on existing accounts.
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
