Skip to content

LG-8336: Implement post timer actions#7577

Merged
jmdembe merged 85 commits intomainfrom
LG-8336-post-timer-actions
Jan 27, 2023
Merged

LG-8336: Implement post timer actions#7577
jmdembe merged 85 commits intomainfrom
LG-8336-post-timer-actions

Conversation

@jmdembe
Copy link
Contributor

@jmdembe jmdembe commented Jan 4, 2023

🎫 Ticket

LG-8336

🛠 Summary of changes

This ticket completes the implementation of the the timer that counts down to when the one-time password expires. Now, we redirect to a page that informs users that their code has expired and to request a new one.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

Before testing

  • add otp_valid_for: 3 to application.yml to speed up testing
  1. Spin up application and log on to `http://localhost:3000
  2. Create new account and follow steps for account creation
    1. On account creation, select phone and backup codes as MFA options for faster testing
  3. Enter phone number to add to the account
  4. On the one time password screen, wait approximately 30 seconds for the countdown banner to appear. The countdown will count down from the set otp_valid_for value
  5. Wait until the timer reaches zero
  6. Redirect to OTP expiration page

Optional: Repeat testing on add phone setup and one time code verification setup on existing accounts.

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.
Screenshot of one-time code expired page

@jmdembe jmdembe force-pushed the LG-8336-post-timer-actions branch from ffe207b to e8d23cb Compare January 4, 2023 19:53
@jmdembe jmdembe force-pushed the LG-8336-post-timer-actions branch from e8d23cb to 736d1e8 Compare January 4, 2023 19:54
changelog: User-Facing Improvements, sms expiration timer, redirect to sms expired
@jmdembe jmdembe force-pushed the LG-8336-post-timer-actions branch from 71240d8 to ce0fe9f Compare January 4, 2023 21:06
@jmdembe jmdembe changed the title LG-83Set redirect to SMS expired page once countdown completes LG-8336: Implement post timer actions Jan 4, 2023
@jmdembe jmdembe force-pushed the LG-8336-post-timer-actions branch from 9ea0f27 to a7749ec Compare January 5, 2023 21:21
@jmdembe jmdembe force-pushed the LG-8336-post-timer-actions branch 2 times, most recently from 6ab6f1c to 18a436a Compare January 25, 2023 19:28
@jmdembe jmdembe force-pushed the LG-8336-post-timer-actions branch from 18a436a to 2b1920a Compare January 25, 2023 19:29
@jmdembe jmdembe force-pushed the LG-8336-post-timer-actions branch from edbfb90 to d34fa58 Compare January 26, 2023 17:47
@jmdembe jmdembe force-pushed the LG-8336-post-timer-actions branch from d34fa58 to 5754cad Compare January 26, 2023 18:45
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, but this is looking good!

jmdembe and others added 3 commits January 27, 2023 09:32
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
@jmdembe jmdembe force-pushed the LG-8336-post-timer-actions branch from b6c5c1b to 47831aa Compare January 27, 2023 16:29
@jmdembe jmdembe merged commit 2e5a156 into main Jan 27, 2023
@jmdembe jmdembe deleted the LG-8336-post-timer-actions branch January 27, 2023 19:08
@zachmargolis zachmargolis mentioned this pull request Jan 30, 2023
aduth added a commit that referenced this pull request Feb 1, 2023
aduth added a commit that referenced this pull request Feb 1, 2023
This reverts commit 2e5a156.

changelog: Bug Fixes, Multi-Factor Authentication, Revert OTP expiration screen due to screen being shown early in some cases
@aduth aduth mentioned this pull request Feb 1, 2023
aduth added a commit that referenced this pull request Feb 1, 2023
* Revert "LG-8336: Implement post timer actions (#7577)"

This reverts commit 2e5a156.

* changelog: Bug Fixes, Multi-Factor Authentication, Revert OTP expiration screen due to screen being shown early in some cases
zachmargolis added a commit that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants