[LG-8794] Add Phone Submit step to daily_dropoffs_report

[orenyk]

Resolves LG-8794

changelog: Internal, Reporting, Add phone submit step to dropoff report

🎫 Ticket

https://cm-jira.usa.gov/browse/LG-8794

[orenyk]

@zachmargolis quick question - how painful would it be to go backfill the old reports with this count so we don't have a weird data discontinuity? Have we done that before for data.login.gov?

[zachmargolis]

@zachmargolis quick question - how painful would it be to go backfill the old reports with this count so we don't have a weird data discontinuity? Have we done that before for data.login.gov?

Backfilling reports is not that painful because we can queue them up in the background, with a change like this we should definitely backfill

[orenyk]

@zachmargolis quick question - how painful would it be to go backfill the old reports with this count so we don't have a weird data discontinuity? Have we done that before for data.login.gov?

Backfilling reports is not that painful because we can queue them up in the background, with a change like this we should definitely backfill

oh that totally makes sense. Would you just do that as a one-off in the console or is it worth adding a quick Rake task to just re-populate the reports?

[zachmargolis]

oh that totally makes sense. Would you just do that as a one-off in the console or is it worth adding a quick Rake task to just re-populate the reports?

Via the console. Something like this (but going back to the first report created in S3, whenever that was)

# in a write console so we can write to the jobs table
(90.days.ago.to_date..Date.yesterday).each { |date| Reports::DailyDropoffsReport.perform_late(date) }

[orenyk]

Makes sense, thanks! Let me know what you think of the PR - I think this should be good to merge!

[zachmargolis]

The PR looks good but I want to make sure that the changes make sense to Team Ada so let's hold off merging just quite yet?

[benjaminchait]

@zachmargolis - @orenyk and i just connected, i understand more about what's happening here and it seems reasonable to me!

[zachmargolis]

LGTM