Skip to content

Move DocAuthLog registration out of shared analytics class#7898

Merged
zachmargolis merged 2 commits intomainfrom
margolis-move-doc-auth-log-out-of-analytics
Feb 28, 2023
Merged

Move DocAuthLog registration out of shared analytics class#7898
zachmargolis merged 2 commits intomainfrom
margolis-move-doc-auth-log-out-of-analytics

Conversation

@zachmargolis
Copy link
Contributor

Cloudwatch query to verify results

  • production.log
fields @timestamp, @message, @logStream, @log
| filter name = 'event_to_doc_auth_log_token'
| sort @timestamp desc
| stats count(*) by source, token, action, success

Results show an exact match between original and proposed giving me a high level of assurance this change should work this time:

Screen Shot 2023-02-27 at 2 06 17 PM

- Builds on logging added in #7864, and is a redo of #7685 now that
  we have logging to ensure better coverage

- Specs were added in #7864
@zachmargolis zachmargolis requested review from a team February 27, 2023 22:07
changelog: Internal, Logging, Move doc auth logging out of shared analytics class
Copy link
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Independently verified via the query that the old/new messages are one-to-one.

@zachmargolis
Copy link
Contributor Author

Looks good! Independently verified via the query that the old/new messages are one-to-one.

Thanks for verifying, Doug! <3

@zachmargolis zachmargolis merged commit 57f43e1 into main Feb 28, 2023
@zachmargolis zachmargolis deleted the margolis-move-doc-auth-log-out-of-analytics branch February 28, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants