Skip to content

Revert "Remove event-specific hooks in Analytics class"#7833

Merged
zachmargolis merged 1 commit intomainfrom
margolis-revert-analytics-breakout
Feb 15, 2023
Merged

Revert "Remove event-specific hooks in Analytics class"#7833
zachmargolis merged 1 commit intomainfrom
margolis-revert-analytics-breakout

Conversation

@zachmargolis
Copy link
Contributor

This reverts commit 1af92c5 (#7685)

changelog: Internal, Reporting, Revert analytics event refactor

After some digging

  • the data.login.gov proofing funnel discrepancies started with the the deploy of the reverted code (slack thread)
  • the code changes how the Phone Submit step event was logged to doc_auth_logs, which was the first 3 subsequent events that started to have off numbers

Next steps:

  • take a look at the doc auth logs reports after this is deployed
  • if no change: revert it back (because the refactor gets the codebase to a better spot, and it didn't affect reporting)
  • if there is a change: try to understand why the refactor wasn't successful

…lling code (#7685)"

This reverts commit 1af92c5.

changelog: Internal, Reporting, Revert analytics event refactor
@zachmargolis zachmargolis requested a review from a team February 14, 2023 22:32
@zachmargolis zachmargolis merged commit 69617af into main Feb 15, 2023
@zachmargolis zachmargolis deleted the margolis-revert-analytics-breakout branch February 15, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants