LG-8754 Persist AB testing values in session WIP#7750
LG-8754 Persist AB testing values in session WIP#7750jess-fortier wants to merge 8 commits intomainfrom
Conversation
…re and concurrent test data
… session and include in logging context
…A Variant analytics event
| # @param [Hash] variant The IPP CTA Variant that was shown to the user | ||
| # The user was shown a variant of the IPP CTA | ||
| def idv_ipp_cta_variant(variant:, **extra) | ||
| preserve_testing_value({ ipp_cta_variant: variant }) |
There was a problem hiding this comment.
I am very skeptical of putting this side effect here. Again, the only purpose of this file is to provide some static definitons we can generate documentation from, I think it would be clearer to move this logic up to the call sites
Take a look at #7685 as an example of removing event-specific side effects.
There was a problem hiding this comment.
I was struggling with the best way to persist a value in session from the doc auth React flow. Could I put some time on your calendar to discuss?
There was a problem hiding this comment.
Could we assign the A/B test bucket to the session before the page is loaded. And then if we need to add that to events for in-person proofing, we could use the existing Idv::AnalyticsEventsEnhancer class to add the variant in dynamically to every event for the in-person flow, since it was designed to add common details to all IPP events.
| preserve_testing_value({ ipp_cta_variant: variant }) | ||
| track_event( | ||
| 'IdV: IPP CTA Variant Displayed', | ||
| **extra, |
There was a problem hiding this comment.
| **extra, | |
| variant: variant, | |
| **extra, |
LG-8754
🛠 Summary of changes
Change event on IPP CTA load
Frontend: IdV: IPP CTA Variant A/Frontend: IdV: IPP CTA Variant B/Frontend: IdV: IPP CTA Variant CIdV: IPP CTA Variant DisplayedStore variant data in session and surface it in future logged events as:
@session[test_data]📜 Testing Plan
LG-8754 Test Plan