Deploy RC 182 to Prod by aduth · Pull Request #6065 · 18F/identity-idp

aduth · 2022-03-15T14:03:12Z

Improvements

Rate Limiting: Allow exceptions to IP-based rate-limiting rules (#6048)
Proofing: Removed expired license allower (#6039)
WebAuthn: Provide better error flow for users who may not be able to leverage WebAuthn (#5976)
Accessibility: Update screen reader message to identify all options (#6044)

Bug Fixes

Reset Password: Fix 500 error when resetting password for account with email confirmed by another account (#6042)
Logging: Fix 500 when parsing browser user-agent that is too long (#6036, #6056)

Internal

Performance: Re-use existing database query results to avoid duplicative work (#6058, #6061)
Data: Create common interface for accessing PII bundle in session (#6054)
Packages: Publish v2.0.0 of ESLint shared configuration (#6062)
Testing: Improve test coverage (#6053)
Database: Modify autovacuum config for devices and users (#6047)
Security: Run JavaScript dependency audit in continuous integration tests (#6045)
Security: Upgrade Rails to patch vulnerability (#6041)

* Truncate large user agents when detecting browser changelog: Bug Fix, Logging, Fix 500 when parsing browser user-agent that is too long * Update app/services/browser_cache.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

- Lets us set log level to minimize STDOUT output from Identity::Hostdata (downloading files from S3, etc) [skip changelog]

* add check to see if platform is available * add alert * LG-5515: add redirect to error page * LG-5515: fix javascript error * LG-5515: put back method used for testing * LG-5515: platform auth normalize yaml and add tests * LG-5515: update rspec for webauthn * LG-5515: update javascript and remove unneeded logging * get rid of select call * LG-5515: update language * grab error from title * changelog: Improvements, Webauthn, Provide better error flow for users who may not be able to leverage webauthn (LG-5515 * LG-5515: rubocop error fix * LG-5515: simplify the webauthn method a little more * LG-5515: add a return * Only add "; Secure" to cookies served over HTTPS * Remove unused constants * LG-5515: webauthn authenticaate support safari * LG-5515: update language for platform auth * test fixes * fix linting, debug Co-authored-by: Jessica Dembe <jessica.dembe@gsa.gov> Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov>

changelog: Internal, Security, Upgrade Rails to patch vulnerability

* Migrate IDV_PHONE_CONFIRMATION_OTP_SUBMITTED event * Migrate IDV_PHONE_CONFIRMATION_OTP_VISIT event * Migrate IDV_PHONE_CONFIRMATION_OTP_VISIT event * Remove IDV_PHONE_ERROR_SUBMITTED, appears never to have been used * Migrate IDV_PHONE_OTP_DELIVERY_SELECTION_SUBMITTED event * [skip changelog]

changelog: Improvements, Proofing, Removed expired license allower Co-authored-by: Manish Shah <manishshah@Manishs-MBP.fios-router.home>

…ail address that has since been confirmed by another account (#6042) * Add failing test changelog: Bug Fixes, Reset Password, Fix 500 error when resetting password for account with email confirmed by another account * Return error on invalid account resetting password * Update app/forms/reset_password_form.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

* allow path exceptions to ip rate limiting changelog: Improvements, Rate Limiting, Allow exceptions to IP-based rate-limiting rules * allow CIDR block exceptions to ip rate limiting * Update config/initializers/rack_attack.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update config/initializers/rack_attack.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

* Migrate ACCOUNT_VISIT analytics event * Migrate AUTHENTICATION_CONFIRMATION analytics event * Migrate AUTHENTICATION_CONFIRMATION_CONTINUE analytics event * Migrate AUTHENTICATION_CONFIRMATION_RESET analytics event * Migrate BANNED_USER_REDIRECT analytics event [skip changelog]

changelog: Internal, Security, Run JavaScript dependency audit in continuous integration tests

#6044) * changelog: Content Change, Update screen reader message to identify all options, LG-5857 * screen reader to read sr_message * explicit modal role

changelog: Bug Fixes, Account Reset, Fix error preventing account reset

changelog: Internal, Database, Modify autovacuum config for devices and users

changelog: Internal, Analytics, Use explicit configuration instead of "magic number" to set length limit on user-agent parsing Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

…6053) * remove unused methods * add spec for logging document error changelog: Internal, Testing, Improve test coverage

changelog: Internal, Background Jobs, Queue PhoneNumberOptOutSyncJob as long running

[skip changelog]

* Revert "Fix 500 during account reset" This reverts commit 1f6e314. * Remove YARD HTML from source code * Require an **extra on analytics events **Why**: To prevent undocumented params from causing errors [skip changelog]

* Prepare v2.0.0 release of ESLint plugin * changelog: Internal, Packages, Publish v2.0.0 of ESLint shared configuration

* Create common interface for accessing PII bundle in session changelog: Internal, Data, Create common interface for accessing PII bundle in session * Update app/controllers/sign_up/completions_controller.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Add method to allow for checking of existence of PII bundle in session Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

* Avoid duplicated hot-path User and ServiceProvider queries changelog: Internal, Performance, Re-use existing database query results to avoid duplicative work * Update app/services/idv/session.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * rename identity linker provider to issuer Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

* Avoid duplicated ServiceProvider queries in IdentityLinker changelog: Internal, Performance, Re-use existing database query results to avoid duplicative work * rename current_service_provider to saml_request_service_provider in saml auth to better distinguish service providers

mitchellhenke

👍🏼

Background Jobs: Queue PhoneNumberOptOutSyncJob as long running (#6055)
Account Reset: Fix error preventing account reset (#6050)

have already been released though

aduth · 2022-03-15T14:16:44Z

have already been released though

Thanks for the heads-up! I'll remove them from the notes.

Should the changelog script be excluding those if they're already on stages/prod? 🤔

zachmargolis

LGTM

zachmargolis · 2022-03-15T15:18:39Z

app/javascript/packs/webauthn-authenticate.js

+    // if platform auth is not supported on device, we should take user to the error screen if theres no additional methods.
+    // if platform auth is not supported on device, we should take user to the error screen if theres no additional methods.


whoops, I bet a merge conflict resulted in us duplicating this line like this, luckily it's a comment so it's a no-op

whoops, I bet a merge conflict resulted in us duplicating this line like this, luckily it's a comment so it's a no-op

👍 Related: #5976 (comment)

Mitchell Henke and others added 22 commits March 7, 2022 12:07

Add LOGIN_TASK_LOG_LEVEL env var (#6037)

07f52dc

- Lets us set log level to minimize STDOUT output from Identity::Hostdata (downloading files from S3, etc) [skip changelog]

Upgrade Rails to 6.1.4.7 (#6041)

acf42f3

changelog: Internal, Security, Upgrade Rails to patch vulnerability

Remove ExpiredLicenseAllower updates (#6039)

5ec2b30

changelog: Improvements, Proofing, Removed expired license allower Co-authored-by: Manish Shah <manishshah@Manishs-MBP.fios-router.home>

Run yarn audit in CI (#6045)

de51d7d

changelog: Internal, Security, Run JavaScript dependency audit in continuous integration tests

changelog: Content Change, Update screen reader message to identify a… (

147995f

#6044) * changelog: Content Change, Update screen reader message to identify all options, LG-5857 * screen reader to read sr_message * explicit modal role

Fix 500 during account reset (#6050)

4241f36

changelog: Bug Fixes, Account Reset, Fix error preventing account reset

Modify autovacuum config for devices and users (#6047)

bfdac3f

changelog: Internal, Database, Modify autovacuum config for devices and users

Remove some unused methods and add specs for LogDocumentError class (#…

ede0486

…6053) * remove unused methods * add spec for logging document error changelog: Internal, Testing, Improve test coverage

Queue PhoneNumberOptOutSyncJob as long running (#6055)

cb4209d

changelog: Internal, Background Jobs, Queue PhoneNumberOptOutSyncJob as long running

knapsack report update (#6057)

7d311ac

[skip changelog]

Require **extra in Analytics Events Documentation (#6052)

93d572b

* Revert "Fix 500 during account reset" This reverts commit 1f6e314. * Remove YARD HTML from source code * Require an **extra on analytics events **Why**: To prevent undocumented params from causing errors [skip changelog]

Prepare v2.0.0 release of ESLint plugin (#6062)

5d7cca3

* Prepare v2.0.0 release of ESLint plugin * changelog: Internal, Packages, Publish v2.0.0 of ESLint shared configuration

aduth added the status - promotion label Mar 15, 2022

aduth requested review from SammySteiner, gsa-manish, jgrevich, jmdembe, mdiarra3, mitchellhenke and zachmargolis March 15, 2022 14:03

mitchellhenke approved these changes Mar 15, 2022

View reviewed changes

zachmargolis approved these changes Mar 15, 2022

View reviewed changes

aduth merged commit f536123 into stages/prod Mar 17, 2022

aduth deleted the stages/rc-2022-03-17 branch March 17, 2022 16:14

aduth mentioned this pull request Sep 16, 2022

Document available changelog categories #6977

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deploy RC 182 to Prod#6065

Deploy RC 182 to Prod#6065
aduth merged 22 commits intostages/prodfrom
stages/rc-2022-03-17

aduth commented Mar 15, 2022 •

edited

Loading

Uh oh!

mitchellhenke left a comment

Uh oh!

aduth commented Mar 15, 2022 •

edited

Loading

Uh oh!

zachmargolis left a comment

Uh oh!

zachmargolis Mar 15, 2022

Uh oh!

aduth Mar 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

		// if platform auth is not supported on device, we should take user to the error screen if theres no additional methods.
		// if platform auth is not supported on device, we should take user to the error screen if theres no additional methods.

Conversation

aduth commented Mar 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Improvements

Bug Fixes

Internal

Uh oh!

mitchellhenke left a comment

Choose a reason for hiding this comment

Uh oh!

aduth commented Mar 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zachmargolis left a comment

Choose a reason for hiding this comment

Uh oh!

zachmargolis Mar 15, 2022

Choose a reason for hiding this comment

Uh oh!

aduth Mar 15, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

aduth commented Mar 15, 2022 •

edited

Loading

aduth commented Mar 15, 2022 •

edited

Loading