Remove some unused methods and add specs for LogDocumentError class#6053
Merged
mitchellhenke merged 2 commits intomainfrom Mar 14, 2022
Merged
Remove some unused methods and add specs for LogDocumentError class#6053mitchellhenke merged 2 commits intomainfrom
mitchellhenke merged 2 commits intomainfrom
Conversation
added 2 commits
March 11, 2022 15:26
changelog: Internal, Testing, Improve test coverage
mitchellhenke
force-pushed
the
mitchellhenke/improve-test-coverage
branch
from
49e80f6 to
b9e9858
Compare
Comment on lines
-202
to
-204
| def aal | ||
| Saml::Idp::Constants::AUTHN_CONTEXT_CLASSREF_TO_AAL[aal_values.sort.max] | ||
| end |
Contributor
There was a problem hiding this comment.
this is very surprising to me that it's not used...? are we getting aal elsewhere?
Contributor
Author
There was a problem hiding this comment.
mitchellhenke
commented
Mar 11, 2022
| I18n.t('errors.messages.confirmation_period_expired', period: confirmation_period) | ||
| end | ||
|
|
||
| def confirmation_period |
Contributor
Author
There was a problem hiding this comment.
This was used, but only in tests, the live usage is actually in ConfirmationEmailPresenter
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.