Avoid duplicated ServiceProvider queries in IdentityLinker#6061
Merged
mitchellhenke merged 2 commits intomainfrom Mar 14, 2022
Merged
Avoid duplicated ServiceProvider queries in IdentityLinker#6061mitchellhenke merged 2 commits intomainfrom
mitchellhenke merged 2 commits intomainfrom
Conversation
zachmargolis
approved these changes
Mar 14, 2022
mitchellhenke
force-pushed
the
mitchellhenke/save-a-query-3
branch
3 times, most recently
from
c7e73db to
8bd8026
Compare
mitchellhenke
force-pushed
the
mitchellhenke/save-a-query-2
branch
from
135bb60 to
d53dc64
Compare
mitchellhenke
force-pushed
the
mitchellhenke/save-a-query-3
branch
from
8bd8026 to
36eb7a5
Compare
mitchellhenke
force-pushed
the
mitchellhenke/save-a-query-2
branch
from
e22242e to
76023ab
Compare
zachmargolis
approved these changes
Mar 14, 2022
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, excited to see what NewRelic looks like after this is deployed
app/services/identity_linker.rb
Outdated
Comment on lines
96
to
99
changelog: Internal, Performance, Re-use existing database query results to avoid duplicative work
mitchellhenke
force-pushed
the
mitchellhenke/save-a-query-3
branch
from
7bb1757 to
578aa7f
Compare
…aml auth to better distinguish service providers
mitchellhenke
force-pushed
the
mitchellhenke/save-a-query-3
branch
from
578aa7f to
17afa42
Compare
Merged
This was referenced Mar 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #6058 to avoid duplicating a
ServiceProvider.findquery inIdentityLinker