Merged
Conversation
changelog: Internal, Security, Run JavaScript dependency audit in continuous integration tests
mitchellhenke
force-pushed
the
mitchellhenke/yarn-audit-ci
branch
from
dff02a4 to
4fdf910
Compare
aduth
approved these changes
Mar 11, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Seems reasonable to me 👍 Like bundler audit, it'll probably be a bit of a nuisance for unrelated build failures, but I think it's a reasonable trade-off considering the advantage of having these issues surfaced ASAP vs. waiting for Dependabot.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently pass this check (I think since #5889), so now may be the most opportune time to add it if we want?