Remove ExpiredLicenseAllower and related code#6039
Merged
gsa-manish merged 1 commit intomainfrom Mar 9, 2022
Merged
Conversation
gsa-manish
force-pushed
the
LG-5889-remove-expiredlicenseallower
branch
from
1c089e5 to
ccd3ef0
Compare
zachmargolis
reviewed
Mar 8, 2022
Contributor
There was a problem hiding this comment.
this should stay, this ticket is to remove the logic based on the error... the error will still be sent by the vendor and we still need to be able to handle it, translate messages, etc etc
app/services/doc_auth/errors.rb
Outdated
app/services/doc_auth/errors.rb
Outdated
app/services/doc_auth_router.rb
Outdated
Comment on lines
23
to
25
Comment on lines
59
to
61
Contributor
There was a problem hiding this comment.
the return value of this method didn't change, let's keep this YARD type annotation?
Contributor
There was a problem hiding this comment.
the reproof_at column isn't being dropped, we should keep this assertion
gsa-manish
force-pushed
the
LG-5889-remove-expiredlicenseallower
branch
4 times, most recently
from
64561cd to
369fc20
Compare
changelog: Improvements, Proofing, Removed expired license allower
gsa-manish
force-pushed
the
LG-5889-remove-expiredlicenseallower
branch
from
369fc20 to
b58b86a
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.