Deploy RC 170 to Production#5707
Merged
mitchellhenke merged 16 commits intostages/prodfrom Dec 16, 2021
Merged
Conversation
* Extract Stylelint configuration for publish to NPM **Why**: So that we can use the same configuration across our projects (e.g. 18f/identity-style-guide). * Format SASS with Prettier * Add custom message clarifying class selector pattern **Why**: So that it's easier to act on an error * Fix Stylelint issues in JS packages * Drop dependency on "standard" Stylelint SCSS Not used, only using its dependency "recommended" * Remove more Prettier-conflicting recommended config **Why**: Because they sometimes can't coexist
**Why**: So that we can track user progression through the flow.
**Why**: Because they exist only as a stopgap for mid-deploy routing, they are no longer needed as of RC169. Previously: #5662
**Why**: So that users in the test envs will know not to enter real SSNs and how to enter valid test SSNs
* Add dev and int smoke tests * only do coverage on push * only run github sync on github sync schedule
* Remove unused personal-key pattern validation message **Why**: Because it's unused. * Remove unused translation strings
**Why**: - Standardize on design system - Smaller bundled output, and faster generation - Avoid ambiguity for developers choosing flex styling
* Update ahoy_matey from 3.1.0 to 3.3.0 * Update autoprefixer-rails from 10.2.5.1 to 10.3.3.0 * Update aws-sdk-cloudwatchlogs from 1.38.0 to 1.49.0 * Update aws-sdk-kms from 1.40.0 to 1.52.0 * Update aws-sdk-pinpoint from 1.48.0 to 1.62.0 * Update aws-sdk-pinpointsmsvoice from 1.21.0 to 1.29.0 * Update aws-sdk-ses from 1.36.0 to 1.44.0 * Update axe-core-rspec from 4.3.0 to 4.3.2 * Update dotiw from 5.1.0 to 5.3.2 * Update faker from 2.18.0 to 2.19.0 * Update faraday from 1.1.0 to 1.8.0 * Update good_job from 2.7.0 to 2.7.3 * Update i18n-tasks from 0.9.34 to 0.9.35 * Update irb from 1.3.6 to 1.3.7 * Update jwt from 2.2.3 to 2.3.0 * Update knapsack from 1.22.0 to 4.0.0 * Update net-sftp from 2.1.2 to 3.0.0 * Update octokit from 4.19.0 to 4.21.0 * Update parallel_tests from 2.29.2 to 3.7.3 * Update phonelib from 0.6.53 to 0.6.54 * Update psych from 3.2.1 to 4.0.2 * Update puma from 5.5.1 to 5.5.2 * Update rack-mini-profiler from 2.3.2 to 2.3.3 * Update rails-erd from 1.6.0 to 1.6.1 * Update redis from 4.4.0 to 4.5.1 * Update rspec-rails from 4.0.1 to 4.1.2 * Update rubocop-rails from 2.5.2 to 2.12.4 * Update ruby-saml from 1.12.2 to 1.13.0 * Update shoulda-matchers from 4.4.1 to 4.5.1 * Update simplecov-cobertura from 1.4.2 to 2.0.0 * Update subprocess from 1.5.4 to 1.5.5 * Update valid_email from 0.1.3 to 0.1.4 * Update webdrivers from 4.6.0 to 4.7.0 * Update webmock from 3.13.0 to 3.14.0 * Update webpacker from 5.3.0 to 5.4.3 * Update xmlenc from 0.7.1 to 0.8.0 * Update analytics spec. * Update ResetPasswordsController spec. * Update tag syntax. * Update tag syntax. * Update tag syntax.
* Remove accept-terms-button in favor of ValidatedFieldComponent **Why**: So that there are fewer validation implementations to maintain or to worry about being consistent amongst each other. * Add missing trailing comma * Use customized error message for rules of use validation * Remove duplicate "Please check this box to continue" string * Revert selector for new account sign-up form "user_terms_accepted" is the ID assigned to this input. For consistency, reference by name instead
* Log all vendor status in VendorStatus#track_event **Why**: So that we're consistently logging status for all vendors, not just for a subset of them. * Remove specific tracking data from VendorOutageController spec **Why**: This is an implementation detail of VendorStatus which should be tested on that class's specs
* LG-5257: Add flow_path to upload payload for document capture * include flow_path in extra attributes for IdV: doc auth image upload form submitted * update specs * flow_path added to async events * pass the flow_path into the document_proofing_job * fix specs for async flow_path Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* LG-5261: Add cancel page logging to "Go Back" button **Why**: So that we can more easily track the user's path through IAL2. * Update spec for cancellations/new view * Enhance CancellationsController spec to assure go_back_path assignment * Add specs for CancellationsController#update
* Update "Frontend" CSS docs to reflect current approach **Why**: - We don't recommend BassCSS - Link to tools (Sass, Stylelint, etc) as a resource for those who may not already be familiar with them - Light explanation of difference between USWDS and LGDS - Mention BEM naming convention for CSS classes - Hints to developers: - Where they learn about available design system components and utilities - Editor integrations for Stylelint & Prettier, to make their lives easier * Revert Prettier proseWrap configuration Because it affects YAML normalization, which we don't want to deal with right now. See: https://github.com/18F/identity-idp/pull/5695/files#r766722452
mitchellhenke
requested review from
aduth,
jmhooper,
kevindayton,
orenyk,
solipet,
stevegsa and
zachmargolis
mitchellhenke
force-pushed
the
stages/rc-2021-12-14
branch
from
31c533f to
27c194b
Compare
stevegsa
approved these changes
Dec 15, 2021
Contributor
Author
Yep, good call |
**Why:** This will allow partners to send back-channel SAML Logout requests instead of redirecting users as part of their logout flow. This controller action leverages the <SessionIndex> element of the SAML request to receive a user's agency UUID and uses the unique_session_id attribute to remotely log out a user from any active session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.