Conversation
**Why**: - Standardize on design system - Smaller bundled output, and faster generation - Avoid ambiguity for developers choosing flex styling
aduth
commented
Dec 13, 2021
| - 'field-dark' | ||
| - 'progress' | ||
| - 'flex-(column|none)' | ||
| - 'flex(-(center|baseline|stretch|start|end|grow|none|first|last))?' |
Contributor
Author
There was a problem hiding this comment.
Note: Not all BassCSS classes are included here, and in the case of flex-column, I removed it from being disallowed. This is because these classes also exist as design system utilities. In most cases, the specific implementation is similar/identical, and the design system will take precedent.
aduth
commented
Dec 13, 2021
| <% end %> | ||
| <div class='container padding-y-1 padding-x-2 desktop:padding-x-0 <%= 'tablet:padding-y-0' if show_language_dropdown %>'> | ||
| <div class='flex flex-align-center flex-justify-center'> | ||
| <div class='flex flex-auto flex-first'> |
Contributor
Author
There was a problem hiding this comment.
flex-first was removed without replacement here. The style effectively applies order: -1. Aside from being a discouraged style, it's also not really necessary here, because it's already the first child in its container.
nathanberg
added a commit
that referenced
this pull request
Dec 16, 2021
* main: (50 commits) LG-5325 Doc Auth: Error dependent hints and enhanced field level errors (#5708) Setup platform authentication (#5632) Remove unused i18n keys by replacing dynamic key generation with static enumeration (#5706) Configure and fix Rubocop redundant disabling/enabling (#5711) LG-4575: accessiblility issue where no file selected still shows after adding file. (#5691) Update rails to 6.1.4.3 (#5710) Add remote SAML Logout endpoint (#5676) Update "Frontend" CSS docs to reflect current approach (#5695) LG-3795 Harden CSP against JSONP endpoints on "safe" domains (#5704) LG-5261: Add cancel page logging to "Go Back" button (#5697) Add flow path to post doc capture submission events (LG-5257) (#5690) Log all vendor status in VendorStatus#track_event (#5703) Remove accept-terms-button in favor of ValidatedFieldComponent (#5687) Upgrade as many outdated Ruby dependencies as possible (LG-3828) (#5694) Remove BassCSS flex-object styling (#5702) Remove unused personal-key pattern validation message (#5701) Smoke tests in GitLab CI (#5699) Show a message in lower envs explaining how to use test SSNs (#5696) Remove temporary routes for SP redirects (#5679) LG-5262: Add logging to continue button on letter wait page (#5688) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
References: