Add flow path to post doc capture submission events (LG-5257)#5690
Merged
Add flow path to post doc capture submission events (LG-5257)#5690
Conversation
**Why**: So that we can use it for server-side logging.
solipet
changed the title
aduth
approved these changes
Dec 13, 2021
app/jobs/resolution_proofing_job.rb
Outdated
|
|
||
| def perform(result_id:, encrypted_arguments:, trace_id:, should_proof_state_id:, | ||
| dob_year_only:, document_expired:) | ||
| dob_year_only:, document_expired:, flow_path: nil) |
Contributor
There was a problem hiding this comment.
Do we need to be handling the flow_path for the resolution job? Or are we just concerned about document capture?
And if yes:
- Should we be putting it into an event payload somewhere?
- How do we want to deal with this other instance of it that can be enqueued later in the flow? (extra context at LG-5122)
Contributor
Author
There was a problem hiding this comment.
No! I guess I got a bit too aggressive adding flow_path everywhere. Removed in 95e7cee
aduth
reviewed
Dec 13, 2021
app/services/idv/agent.rb
Outdated
Contributor
There was a problem hiding this comment.
Same note as in #5690 (comment), though I expect (hope) that the tests will fail on the mismatch of keyword arguments being passed to ResolutionProofingJob.
solipet
force-pushed
the
lg-5257-doc-capture-flow-path
branch
from
02cc60a to
95e7cee
Compare
nathanberg
added a commit
that referenced
this pull request
Dec 16, 2021
* main: (50 commits) LG-5325 Doc Auth: Error dependent hints and enhanced field level errors (#5708) Setup platform authentication (#5632) Remove unused i18n keys by replacing dynamic key generation with static enumeration (#5706) Configure and fix Rubocop redundant disabling/enabling (#5711) LG-4575: accessiblility issue where no file selected still shows after adding file. (#5691) Update rails to 6.1.4.3 (#5710) Add remote SAML Logout endpoint (#5676) Update "Frontend" CSS docs to reflect current approach (#5695) LG-3795 Harden CSP against JSONP endpoints on "safe" domains (#5704) LG-5261: Add cancel page logging to "Go Back" button (#5697) Add flow path to post doc capture submission events (LG-5257) (#5690) Log all vendor status in VendorStatus#track_event (#5703) Remove accept-terms-button in favor of ValidatedFieldComponent (#5687) Upgrade as many outdated Ruby dependencies as possible (LG-3828) (#5694) Remove BassCSS flex-object styling (#5702) Remove unused personal-key pattern validation message (#5701) Smoke tests in GitLab CI (#5699) Show a message in lower envs explaining how to use test SSNs (#5696) Remove temporary routes for SP redirects (#5679) LG-5262: Add logging to continue button on letter wait page (#5688) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our logging for flow path don't include flow path for
IdV: doc auth image upload form submitted,IdV: doc auth image upload vendor submitted, andIdV: doc auth image upload vendor pii validation.By not having this we can't differentiate in the logs between hybrid and normal flow for these events.