Merged
Conversation
…#11777) changelog: Bug Fixes, Data Warehouse, Skip S3 upload if bucket name is blank
changelog: Bug Fixes, SAML, Return error when SAML year is invalid
* changelog: Upcoming Features, socure, try again if socure url not found * Adding test for not showing rate limit text if url not found * Resolving PR comments * Reverting param change, fixing lint, hoping to fix tests * switch to symbol check and strong params. fixing lint and test
* Fail louder on missing translation data changelog: Internal, Localization, Improve reliability of JavaScript string extraction * Use more specific behavior in changelog note * Remove TypeScript exception for ported file * Exclude test environment from logging * Add environment expectation tests for i18n logging * Assign console variable to eliminate repetition See: https://github.com/18F/identity-idp/pull/11776/files#r1924142466 Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Avoid assigning console property for storing unverified messages * Improve type annotations * Add type annotation for loggedError implementation --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Update Pinpoint supported countries - Run `make lint_country_dialing_codes` * Update Sender ID support countries * Specs for Registration Required^9 * PR feedback: make ^9 about checking against Sender ID list * Add manual overrides back to existing configuration changelog: Internal, SMS support, Update parsing of supported countries for SMS
#11780) * adding SAML2025 example certs + references, updating tests to use them * changelog: Internal, SAML, adding SAML2025 files/refs (gitlab/TeamRadia#270)
* LG-12534 Remove flow_state_machine.rb and add index action to in person controller changelog: Internal, In-person proofing, cleaning up unused FSM code
* Update alternative content for Face/Touch recommended test changelog: Upcoming Features, Multi-Factor Authentication, Update alternative content for Face/Touch recommended test * Remove spec for removed link * Remove unused string
aduth
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
Internal
Upcoming Features