Return error when SAML year is invalid#11766
Merged
mitchellhenke merged 1 commit intomainfrom Jan 21, 2025
Merged
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/do-not-raise-exception-on-missing-year
branch
from
bca38bc to
04f93ba
Compare
changelog: Bug Fixes, SAML, Return error when SAML year is invalid
mitchellhenke
force-pushed
the
mitchellhenke/do-not-raise-exception-on-missing-year
branch
from
04f93ba to
9007544
Compare
mitchellhenke
deleted the
mitchellhenke/do-not-raise-exception-on-missing-year
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
We currently raise an unhandled exception in some cases when receiving a request for a SAML year that is not currently configured. This PR stores the SAML years from
AppArtifactsin a constant and adds a year check to the SAML controller that returns an error if the year is not available.