Skip to content

lg-14952 Try Again if Document Request fails#11770

Merged
AShukla-GSA merged 5 commits intomainfrom
lg-14952-try-again-if-doc-request-fails-w-abstract
Jan 21, 2025
Merged

lg-14952 Try Again if Document Request fails#11770
AShukla-GSA merged 5 commits intomainfrom
lg-14952-try-again-if-doc-request-fails-w-abstract

Conversation

@AShukla-GSA
Copy link
Contributor

🎫 Ticket

Link to the relevant ticket:
LG-14952

🛠 Summary of changes

Abstracted out timeout to general error, and added url_not_found case. Also added functionality to not display rate limit text if url not found for both standard and hybrid flows.

@AShukla-GSA AShukla-GSA force-pushed the lg-14952-try-again-if-doc-request-fails-w-abstract branch from 87ed61a to bfd4758 Compare January 17, 2025 18:53
Copy link
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few quick comments

@AShukla-GSA AShukla-GSA requested a review from solipet January 21, 2025 14:45
Copy link
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AShukla-GSA AShukla-GSA force-pushed the lg-14952-try-again-if-doc-request-fails-w-abstract branch from 2e03646 to 82eddd9 Compare January 21, 2025 16:41
@AShukla-GSA AShukla-GSA merged commit 024ca38 into main Jan 21, 2025
@AShukla-GSA AShukla-GSA deleted the lg-14952-try-again-if-doc-request-fails-w-abstract branch January 21, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants