Skip S3 upload for daily sensitive column job if bucket name is blank#11777
Merged
mitchellhenke merged 1 commit intomainfrom Jan 21, 2025
Merged
Conversation
aduth
approved these changes
Jan 21, 2025
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Should we just avoid running this job altogether if it's not configured to be uploaded to S3 ?
mitchellhenke
force-pushed
the
mitchellhenke/skip-daily-sensitive-upload-if-bucket-name-is-blank
branch
from
e57eaa2 to
7e3aaa4
Compare
aduth
reviewed
Jan 21, 2025
changelog: Bug Fixes, Data Warehouse, Skip S3 upload if bucket name is blank
mitchellhenke
force-pushed
the
mitchellhenke/skip-daily-sensitive-upload-if-bucket-name-is-blank
branch
from
7e3aaa4 to
3d8a1f6
Compare
Contributor
Author
I mostly lean towards minimizing the change in functionality as I don't know that there's not utility in the job running even if it's not uploading to S3. |
mitchellhenke
deleted the
mitchellhenke/skip-daily-sensitive-upload-if-bucket-name-is-blank
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This job currently fails when there is no S3 bucket configured, though it looks like it intends to skip. This PR makes a small change to where the check happens and skips upload to S3 if the configured bucket name is blank.