Conversation
There was a problem hiding this comment.
This file removal is a long time coming! Excited to see it happening.
jennyverdeyen
force-pushed
the
jverdeyen/LG-12534-FSM-clean-up
branch
from
f9d621b to
7174c83
Compare
jennyverdeyen
changed the title
jennyverdeyen
force-pushed
the
jverdeyen/LG-12534-FSM-clean-up
branch
3 times, most recently
from
b8e2b3b to
2162849
Compare
…on controller changelog: Internal, In-person proofing, cleaning up unused FSM code
…s breaking after removing the dynamic FSM /:step route
jennyverdeyen
force-pushed
the
jverdeyen/LG-12534-FSM-clean-up
branch
from
6b536d8 to
4386652
Compare
jennyverdeyen
changed the title
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
I tested locally and used telephony to test the hybrid flow. Things worked well. Approved.
| :ensure_correct_step, | ||
| :set_usps_form_presenter, | ||
| :redirect_unless_enrollment, | ||
| :initialize_in_person_session, |
There was a problem hiding this comment.
Good to see this added. 💪🏻
There was a problem hiding this comment.
I was going to ask if there's a benefit to increasing test coverage for the functionality of theinitialize_in_person_session method, but I realize it's tricky to test private methods. I'm curious what you think.
There was a problem hiding this comment.
Good suggestion! I added a test to in_person_controller_spec to check that the session is initialized correctly when the index action is called, which indirectly tests the initialize_in_person_session method 👍
| step_url = local_assigns[:step_url] || @step_url | ||
| step = local_assigns[:action] || local_assigns[:step] | ||
| path = (step_url && step) ? send(step_url, step: step) : go_back_path | ||
| path = go_back_path |
| step_url = local_assigns[:step_url] || @step_url | ||
| step = local_assigns[:action] || local_assigns[:step] | ||
| path = (step_url && step) ? send(step_url, step: step) : go_back_path |
There was a problem hiding this comment.
Can we update the code documentation above to remove action and step_url if they're no longer relevant?
jennyverdeyen
force-pushed
the
jverdeyen/LG-12534-FSM-clean-up
branch
from
2ab0c8e to
94efd3f
Compare
3 participants
🎫 Ticket
Link to the relevant ticket:
LG-12534
🛠 Summary of changes
Removes remaining Flow State Machine related files and references
📜 Testing Plan
No new functionality is being added, but manual regression testing is needed to ensure nothing has been adversely affected.