Deploy RC 438 to Production#11632
Merged
eileen-nava merged 7 commits intostages/prodfrom Dec 12, 2024
Merged
Conversation
* Expand on form pattern documentation validation, error handling changelog: Internal, Documentation, Expand on form pattern documentation validation, error handling * Fix typo Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov> --------- Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
…g service provider (#11606) This commit adds a new alert to the account page. This alert appears when a user has completed IdV, but has not connected their account to their SP (i.e. they have not gone back to the SP and done a verified sign in since completing IdV). If a link to the SP is available, a link to go back to the SP is provided. changelog: User-Facing Improvements, Account screen, Add a new link to return to the service provider for verified users who have not connected their account yet.
changelog: Internal, Dcoumentation, Add Frontend documentation for Images best practices
changelog: Internal, OpenID Connect, Validate identity provider public/private keys Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Adding functionality and test for standard controller * Adding logic to hybrid controller, pausing to wait for feature test infastructure * Resolving PR comments, spec test fails due to capture app reset error * Resolving PR comments * Resolving PR comments * Fixing rebase * changelog: Upcoming Features, socure, reuse socure valid urls * Resolving PR comments * Fixing test * Resolving pr comments * Resolving PR additions
* changelog: Bug Fixes, SAML Integration, Adding condition to allow no certs if integration has block_encryption set to none
… record (#11315) * Ensure the in-person verifcation profile has an enrollment record In theory, it should never happen that the profile is pending verification and the enrollment record does not exist. changelog: Internal, Automated Testing, Improve test setup for enrolling profiles * fix association for in_person_enrollment pending trait and setup for user with_pending_in_person_enrollment trait * fix setup in individual specs * Add and update traits in profile and users factory * Update spec/factories/in_person_enrollments.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * remove extraneous setup from profile model spec --------- Co-authored-by: Eileen McFarland <80347702+eileen-nava@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
eileen-nava
requested review from
AShukla-GSA,
Sgtpluck,
aduth,
h-m-m,
jmhooper,
mitchellhenke and
zachmargolis
aduth
approved these changes
Dec 12, 2024
mitchellhenke
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal
Upcoming Features