Add Frontend documentation for Images best practices#11613
Merged
Conversation
changelog: Internal, Dcoumentation, Add Frontend documentation for Images best practices
aduth
requested review from
jmdembe,
lmgeorge,
shanechesnutt-ft and
vrajmohan
shanechesnutt-ft
approved these changes
Dec 10, 2024
Contributor
shanechesnutt-ft
left a comment
shanechesnutt-ft
left a comment
There was a problem hiding this comment.
This looks good to me! 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates Frontend documentation to include a section about images: what formats are expected, how they're optimized, and exceptions.
This builds upon a section started in #11381, generalized to images more broadly. It's based on a conversation I had in Slack with another developer who was adding an email image, which are an exception to the common rule of using SVG, and must be optimized manually.
📜 Testing Plan
Verify that the proposed content makes sense.