Allow no certs if block_encryption is set to 'none'#11616
Merged
Conversation
…certs if integration has block_encryption set to none
mitchellhenke
approved these changes
Dec 10, 2024
Jeremy1026
approved these changes
Dec 10, 2024
eileen-nava
pushed a commit
that referenced
this pull request
Dec 10, 2024
* changelog: Bug Fixes, SAML Integration, Adding condition to allow no certs if integration has block_encryption set to none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to the relevant slack conversation:
🛠 Summary of changes
Recently we added an error condition for when a partner does not have a certificate set, designed to help partners in the integration environment. It was believed this would not impact partners in product because the only two active, non-pkce integrations that did not have certificates were actually staging integrations.
However, one of our partners has pkce set, but is using SAML in the web, and so got caught in this error. They have
block_encryptionset tonone, so they don't need a certificate.This change adds a condition where if a partner does not have any registered certificates, BUT is not requesting encrypted responses, then it will not error out.
Write a brief description of what you changed.
-->