Lg-14794 reuse valid capture app url#11555
Merged
AShukla-GSA merged 11 commits intomainfrom Dec 10, 2024
Merged
Conversation
AShukla-GSA
force-pushed
the
lg-14794-reuse-valid-capture-app-url
branch
from
b8a966c to
e052be3
Compare
amirbey
reviewed
Nov 27, 2024
| uuid: document_capture_session_uuid, | ||
| ) | ||
| if document_capture_session.socure_docv_capture_app_url.present? | ||
| @url = document_capture_session.socure_docv_capture_app_url |
Contributor
There was a problem hiding this comment.
since we've added the interstitial page ... it appears we no longer need the other instance variables below ... as opposed to cleaning up here. however, i think it'd be easier to rid of them in LG-14279
amirbey
reviewed
Nov 27, 2024
amirbey
reviewed
Nov 27, 2024
| ) | ||
|
|
||
| if document_capture_session.socure_docv_capture_app_url.present? | ||
| @url = document_capture_session.socure_docv_capture_app_url |
Contributor
There was a problem hiding this comment.
since we've added the interstitial page ... it appears we no longer need the other instance variables below ... as opposed to cleaning up here. however, i think it'd be easier to rid of them in LG-14279
amirbey
reviewed
Nov 27, 2024
app/controllers/idv/hybrid_mobile/socure/document_capture_controller.rb
Outdated
Show resolved
Hide resolved
amirbey
reviewed
Nov 27, 2024
spec/controllers/idv/socure/document_capture_controller_spec.rb
Outdated
Show resolved
Hide resolved
amirbey
reviewed
Nov 27, 2024
spec/controllers/idv/hybrid_mobile/socure/document_capture_controller_spec.rb
Outdated
Show resolved
Hide resolved
amirbey
reviewed
Nov 27, 2024
amirbey
reviewed
Nov 27, 2024
zachmargolis
reviewed
Dec 2, 2024
spec/controllers/idv/socure/document_capture_controller_spec.rb
Outdated
Show resolved
Hide resolved
AShukla-GSA
force-pushed
the
lg-14794-reuse-valid-capture-app-url
branch
from
0ecc921 to
a1b585f
Compare
amirbey
reviewed
Dec 5, 2024
spec/controllers/idv/socure/document_capture_controller_spec.rb
Outdated
Show resolved
Hide resolved
amirbey
reviewed
Dec 5, 2024
spec/controllers/idv/hybrid_mobile/socure/document_capture_controller_spec.rb
Outdated
Show resolved
Hide resolved
amirbey
reviewed
Dec 5, 2024
spec/controllers/idv/hybrid_mobile/socure/document_capture_controller_spec.rb
Outdated
Show resolved
Hide resolved
amirbey
reviewed
Dec 5, 2024
amirbey
reviewed
Dec 5, 2024
amirbey
reviewed
Dec 5, 2024
amirbey
reviewed
Dec 5, 2024
amirbey
reviewed
Dec 5, 2024
amirbey
approved these changes
Dec 6, 2024
AShukla-GSA
force-pushed
the
lg-14794-reuse-valid-capture-app-url
branch
from
e39c18b to
ef99276
Compare
amirbey
reviewed
Dec 9, 2024
amirbey
reviewed
Dec 9, 2024
AShukla-GSA
force-pushed
the
lg-14794-reuse-valid-capture-app-url
branch
from
4f64688 to
8f6a8e9
Compare
AShukla-GSA
force-pushed
the
lg-14794-reuse-valid-capture-app-url
branch
from
8f6a8e9 to
8d3265f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-14794
🛠 Summary of changes
Reuse socure capture app url when we can, also adding feature tests aligned with test scenarios listed in the ticket.