Validate OIDC identity provider public/private keys#11612
Merged
mitchellhenke merged 1 commit intomainfrom Dec 10, 2024
Merged
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/validate-openid-connect-certs
branch
from
3dc24e5 to
4e18441
Compare
zachmargolis
approved these changes
Dec 9, 2024
lib/openid_connect_key_validation.rb
Outdated
Contributor
There was a problem hiding this comment.
What if we provided a default data generator? the bit in app_artifacts.rb seems arbitrary and isn't clear what it's used for
Suggested change
| def self.valid?(private_key:, public_key:, data:) | |
| def self.valid?(private_key:, public_key:, data: SecureRandom.hex) |
Contributor
Author
There was a problem hiding this comment.
yep, makes sense
Sgtpluck
approved these changes
Dec 10, 2024
Contributor
Sgtpluck
left a comment
Sgtpluck
left a comment
There was a problem hiding this comment.
agree with zach's suggestion, but looks good
mitchellhenke
force-pushed
the
mitchellhenke/validate-openid-connect-certs
branch
from
4e18441 to
cdf3f70
Compare
changelog: Internal, OpenID Connect, Validate identity provider public/private keys Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
force-pushed
the
mitchellhenke/validate-openid-connect-certs
branch
from
cdf3f70 to
89dfd05
Compare
mitchellhenke
deleted the
mitchellhenke/validate-openid-connect-certs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of work to allow zero down-time rotation of OIDC keys, this is an initial step to validate that the keys are minimally correct before we potentially add more keys into the mix. It's brief, but ensures that the private key can sign data that is verifiable by the public key.