Merged
Conversation
changelog: Internal, Code Cleanup, Remove legacy favicon assets
* LG-14010 - More detailed error page for Socure errors Added plumbing and UX display for categorized Socure errors. changelog: Upcoming Features, Socure, Added nice error display for Socure failures
…sign-in (#11580) * LG-15183: Associate user_id for reCAPTCHA result analytics of failed sign-in changelog: Internal, Anti-Fraud, Associate user_id for reCAPTCHA result analytics of failed sign-in * Add FakeAnalytics#reset! to support resetting analytics stub * Assert SessionsController user through stub_analytics * Move SessionsController#analytics_user to public Match ApplicationController#analytics_user visibility
* Add additional logging details for partner email selection changelog: Internal, Analytics, Add additional logging details for partner email selection * Avoid logging from_select_email_flow in sign up email confirmation Not relevant for this flow. Unfortunate consequence of sharing event between initial account creation email confirmation, and subsequent email additions * Drop from_select_email_flow from signup email confirmed Never present * Use attr_reader shorthand for selected_email_id * Default token validator from_select_email_flow to nil Avoid in logging result except where used in account email controller * Omit nil values from extra token validator analytics UndocumentedParams checker still flags if passed as nil, avoid passing altogether Effect on user_id should be non-regressing, since user_id should only supersede default if associated with a user * Include nil user_id in extra token attributes Required keyword argument on add_email_confirmation, avoid regressing * Restore nil user_id assertion in token validator spec * Avoid handling email select flow in token validator Since it's shared, and only 1 place needs this in logging result, instead append to logging result from controller * Use Object#try to convert param to numeric Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Restore presence check Avoid logging 0 ID for empty value --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* add analytics event for when users visits connected accounts page changelog: Internal, logging bugfix, add logging event for connected accounts page visit * add supporting test * lintfix: event in alphabetical order * Update app/controllers/accounts/connected_accounts_controller.rb Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * flatten test --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
…op (#11347) * add desktop ab test information to form * add a/b test configuration * remove anything related to ab test bucket * add passkey support on desktop * remove device supported check * show_unsupported_passkey_platform_authentication_setup * fix associated test * changelog: Upcoming Features, desktop f/t unlock, A/B setup for desktop f/t unlock * fix js test * remove `deskton_ab_bucket?`; remove device does not support passkey tests * note to self * restore `isWebauthnPaskeySupported` * remove desktop qualifying fns, change logic for supported and available devices * restore `show_unsupported_passkey` functionality * lintfixes * fix tests * remove `@desktop_ab_test_bucket` * rename to `desktop_ft_unlock_setup_option_percent_tested` * work on specs for A/B test * add tag so that functionality to show/hide can be in place * toggle show based on english language * restore conditional to show based on A/B enablement * add javascript test * lintfix * changelog: Upcoming Features, A/B test, create A/B test for desktop F/T unlock setup * fix setup for desktop f/t unlock test * lintfixes * track event when user is in a/b test but would not show otherwise * WIP: show/hide based on bucket * Add component tests for desktop-ft-unlock-option * Add controller specs for presenter assigns ab test value * Fix syntax error on assignment * Add feature test for A/B test setup on desktop * fix js code and tests * fix tests and associated logic * add desktop ft unlock capability on login options * set logic for `desktop-ft-unlock-option` class on sign in for test * show/hide based on value * fix error on line * remove * rename bucket, remove a/b test setup from log in files, pass bucket percentage to sign up screen * lintfix * fix js test * js lintfixes * fix F/T unlock show logic * fix for f/t unlock logic? * fix javascript test * remove unneeded logic from input element, remove `trackEvent` * lintfix, change default config number * more lintfixes * clean up hidden and webauthn-input-element specs * Update app/components/webauthn_input_component.rb Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * Update app/javascript/packages/webauthn/webauthn-input-element.ts Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * update test * delete unused analytics event * change analytics event, remove duplicate a/b test * do check for bucket type * set up method if in bucket and test is running * check for A/B test flag * For bucket check, change value type and fix test * fix js test * lintfix * remove desktop only check * Update app/controllers/users/two_factor_authentication_setup_controller.rb Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * add test that should not have been deleted * change definition name * lintfix by changing name of method * add `User Registration: 2FA Setup visited` to `DESKTOP_FT_UNLOCK_SETUP` A/B test * change placement of test * remove duplicate test * lintfix --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
changelog: Internal, Dependencies, Update dependency to resolve security advisory
* Update Rubocop to 1.69 changelog: Internal, Dependencies, Update dependencies to latest version * Update custom linters to extend base class Avoid deprecation warnings: "Inheriting from `RuboCop::Cop::Cop` is deprecated. Use `RuboCop::Cop::Base` instead." * Update Rubocop plugin gems * Remove unnecessary use of unsupported location arg * Fix existing issues after upgrade * Enable newly-available cops from Rubocop plugins * Remove more usage of unsupported location argument
See https://cm-jira.usa.gov/browse/LG-14520 changelog: Internal, reCAPTCHA, Configure timeouts for reCAPTCHA requests * Remove redundant configuration of specific timeouts in other places in the code as the generic timeout parameter should cover it.
…11593) changelog: Upcoming Features, SAML, Update saml_idp gem to add support for AES-GCM encryption algorithms
* default users requiring facial match to LN changelog: Upcoming Features, IdV Socure, default users requiring facial match to LN * add check for mock vendor * also route to mock for doc auth vendor * add mock to doc auth buckets * changed some vot specs to acr * change doc_auth_vendor to nil if LN is disabled * Update app/controllers/concerns/idv/doc_auth_vendor_concern.rb Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov> * change doc auth vendor bucketing Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov> * add vendor_switching_enabled to tests * remove unused function in doc_auth_vendor_concern --------- Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
* changelog: Upcoming Features, Authentication, Threatmetrix API add local_attribute_1 for user when available * change strong migration back * remove &. for service provider * add new line
* Exclude old IAAs from Combined Invoice Supplement Report V2 changelog: Internal, Reporting, Exclude old IAAs from Combined Invoice Supplement Report V2 * Add spec
* delete spec scaffolding that appears unused * refactor idp/constants.rb and usage of constants * delete unnecessary code * refactor test setup for clarity * continue auditing and ipp refactoring specs * create usps ipp service helper * Changelog: Internal, In-person proofing, audit and update test mock data and helper functions for ipp * respond to feedback * fix feature tests that broke due to helper method refactoring * fix another broken feature test
mitchellhenke
approved these changes
Dec 5, 2024
aduth
approved these changes
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal
Upcoming Features