LG-15155: Logging when user visits connected accounts page#11554
Merged
LG-15155: Logging when user visits connected accounts page#11554
Conversation
aduth
reviewed
Nov 25, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Can we add some test coverage please?
Contributor
Author
Yes, I forgot to put this PR in draft status |
changelog: Internal, logging bugfix, add logging event for connected accounts page visit
jmdembe
force-pushed
the
jd-LG-15155-connected-accounts-analytics
branch
from
bfc0aa0 to
17dc025
Compare
jmdembe
force-pushed
the
jd-LG-15155-connected-accounts-analytics
branch
2 times, most recently
from
c2e6e90 to
138eace
Compare
jmdembe
force-pushed
the
jd-LG-15155-connected-accounts-analytics
branch
from
138eace to
29192da
Compare
mdiarra3
approved these changes
Nov 27, 2024
aduth
reviewed
Dec 2, 2024
Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
aduth
approved these changes
Dec 2, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Minor comment, but otherwise LGTM 👍
Contributor
There was a problem hiding this comment.
Thanks for adding this spec file 🙌
spec/controllers/accounts/connected_accounts_controller_spec.rb
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-15155
🛠 Summary of changes
This is a bug ticket.
This adds a logging event for when users visit the connected accounts page
📜 Testing Plan
Required
make watch_eventsis running in the backgroundBefore:
Current behavior: visiting the connected accounts page would not be logged
Expected behavior: once visited, the
connected_accounts_page_visitedevent will be shown in the console.Screenshot