LG-14813 default users requiring facial match to LN by theabrad · Pull Request #11531 · 18F/identity-idp

theabrad · 2024-11-20T16:54:08Z

🎫 Ticket

Link to the relevant ticket:
LG-14813

🛠 Summary of changes

If a user is going through IdV with a Service Provider requiring facial match, we want to default them to Lexis Nexis and not have them go through Socure.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

Set doc_auth_vendor_default: 'socure' in application.yml
Go through IdV with Facial Match required.
Confirm that you are sent through the LN flow instead of socure
Try going through IdV without facial match required.
Confirm you are sent through the Socure flow.

changelog: Upcoming Features, IdV Socure, default users requiring facial match to LN

…3-facial-match-default

AShukla-GSA

LGTM!

amirbey · 2024-11-21T23:34:50Z

app/controllers/concerns/idv/doc_auth_vendor_concern.rb

    # @returns[String] String identifying the vendor to use for doc auth.
    def doc_auth_vendor
-      bucket = ab_test_bucket(:DOC_AUTH_VENDOR)
+      if resolved_authn_context_result.facial_match? && default_vendor_is_not_mock?


could we have mock, lexisnexis and socure enabled at the same time. what if a facial match is required and the default vendor is :mock? would a user be routed to a vendor that does not support facial match? 🤔

yeah, say default is socure and facial match is requested. Maybe:

bucket = ab_test_bucket(:DOC_AUTH_VENDOR if resolved_authn_context_result.facial_match? && bucket != :mock bucket = :lexis_nexus end

furthering Doug's point ... this appears to assume that mock or lexis nexis is enabled as a doc auth vendor. It seems that we'd need to know whether a vendor is enabled before routing to that vendor. what happens if only socure is enabled, would we have a doc auth vendor when a facial match is req'd 🤔

yeah, say default is socure and facial match is requested. Maybe:

bucket = ab_test_bucket(:DOC_AUTH_VENDOR if resolved_authn_context_result.facial_match? && bucket != :mock bucket = :lexis_nexus end

We want to bypass A/B test bucketing if facial match is required.

furthering Doug's point ... this appears to assume that mock or lexis nexis is enabled as a doc auth vendor. It seems that we'd need to know whether a vendor is enabled before routing to that vendor. what happens if only socure is enabled, would we have a doc auth vendor when a facial match is req'd 🤔

If LN is not enabled should we just redirect them to an error page?

furthering Doug's point ... this appears to assume that mock or lexis nexis is enabled as a doc auth vendor. It seems that we'd need to know whether a vendor is enabled before routing to that vendor. what happens if only socure is enabled, would we have a doc auth vendor when a facial match is req'd 🤔

If LN is not enabled should we just redirect them to an error page?

i tested the current behavior when a vendor is not defined, then the doc_auth_vendor defaults to (default_doc_auth_vendor which is nil). In the unlikely event there is a configuration error, if a user requires a facial match and only socure is configured, should we route the user to socure or standard document capture with a nil vendor (resulting in the screenshot below) @tahineemay?

In this unlikely case, that a user requires facial match and only Socure is configured, we have to throw and error to help surface the misconfiguration. We cannot have the user go through a non-IAL2 IDV, if that is their requirement.

as per @tahineemay response we should return the doc_auth_vendor should be nil which is inline with the current behavior when there is no vendor 👍🏿

btw, when doc_auth_vendor is nil, this ticketed bug is throwing a 500. for your testing it maybe helpful to comment out the redirect_to_correct_vendor when testing doc_auth_vendor is nil 👍🏿

amirbey · 2024-11-21T23:37:56Z

spec/controllers/idv/hybrid_mobile/socure/document_capture_controller_spec.rb

-      let(:idv_vendor) { Idp::Constants::Vendors::LEXIS_NEXIS }
+      context 'when doc_auth_vendor is Lexis Nexis' do
+        let(:idv_vendor) { Idp::Constants::Vendors::LEXIS_NEXIS }


thanks 🙏🏿

amirbey

what if mock is default vendor and facial match is req'd? do we have testing for this?

solipet · 2024-11-22T22:09:37Z

spec/controllers/idv/hybrid_mobile/entry_controller_spec.rb

        {}
      end
      let(:idv_vendor) { Idp::Constants::Vendors::MOCK }
+      let(:vot) { 'P1' }


Vectors of Trust is deprecated and slated to be removed. 😢

app/controllers/concerns/idv/doc_auth_vendor_concern.rb

amirbey · 2024-12-02T17:00:32Z

app/controllers/concerns/idv/doc_auth_vendor_concern.rb

+
+    def lexis_nexis_not_enabled?
+      (IdentityConfig.store.doc_auth_vendor_default == Idp::Constants::Vendors::SOCURE ||
+        IdentityConfig.store.doc_auth_vendor_default.nil?) &&
+        IdentityConfig.store.doc_auth_vendor_lexis_nexis_percent == 0
+    end


Suggested change

def lexis_nexis_not_enabled?

(IdentityConfig.store.doc_auth_vendor_default == Idp::Constants::Vendors::SOCURE ||

IdentityConfig.store.doc_auth_vendor_default.nil?) &&

IdentityConfig.store.doc_auth_vendor_lexis_nexis_percent == 0

end

Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>

amirbey · 2024-12-03T20:47:31Z

app/controllers/concerns/idv/doc_auth_vendor_concern.rb

+    def default_vendor_is_not_mock?
+      IdentityConfig.store.doc_auth_vendor_default != Idp::Constants::Vendors::MOCK
+    end


Suggested change

def default_vendor_is_not_mock?

IdentityConfig.store.doc_auth_vendor_default != Idp::Constants::Vendors::MOCK

end

doesn't seem we're still using this 🤔

amirbey

LGTM ...thanks @theabrad

default users requiring facial match to LN

cb0eec1

changelog: Upcoming Features, IdV Socure, default users requiring facial match to LN

theabrad requested review from AShukla-GSA, amirbey, jmax-gsa and solipet November 20, 2024 16:54

theabrad added 2 commits November 20, 2024 13:34

Merge branch 'main' of github.com:18F/identity-idp into abrad-lg-1481…

525f020

…3-facial-match-default

add check for mock vendor

0b53d6a

AShukla-GSA approved these changes Nov 21, 2024

View reviewed changes

amirbey reviewed Nov 21, 2024

View reviewed changes

amirbey requested changes Nov 21, 2024

View reviewed changes

also route to mock for doc auth vendor

186fbad

amirbey self-requested a review November 22, 2024 19:47

add mock to doc auth buckets

cbb481d

solipet reviewed Nov 22, 2024

View reviewed changes

theabrad added 2 commits November 25, 2024 11:46

changed some vot specs to acr

f466567

change doc_auth_vendor to nil if LN is disabled

eeb1cd2

amirbey reviewed Dec 2, 2024

View reviewed changes

app/controllers/concerns/idv/doc_auth_vendor_concern.rb Outdated Show resolved Hide resolved

amirbey reviewed Dec 2, 2024

View reviewed changes

app/controllers/concerns/idv/doc_auth_vendor_concern.rb Outdated Show resolved Hide resolved

amirbey reviewed Dec 2, 2024

View reviewed changes

theabrad and others added 3 commits December 3, 2024 13:15

Update app/controllers/concerns/idv/doc_auth_vendor_concern.rb

d38a8a9

Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>

change doc auth vendor bucketing

2b3b086

Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>

add vendor_switching_enabled to tests

d0dd148

amirbey reviewed Dec 3, 2024

View reviewed changes

remove unused function in doc_auth_vendor_concern

3a3803f

amirbey approved these changes Dec 3, 2024

View reviewed changes

theabrad merged commit 48da2e9 into main Dec 5, 2024

theabrad deleted the abrad-lg-14813-facial-match-default branch December 5, 2024 14:28

matthinz mentioned this pull request Dec 5, 2024

Deploy RC 436 to Production #11600

Merged

	def default_vendor_is_not_mock?
	IdentityConfig.store.doc_auth_vendor_default != Idp::Constants::Vendors::MOCK
	end

Conversation

theabrad commented Nov 20, 2024

🎫 Ticket

🛠 Summary of changes

📜 Testing Plan

Uh oh!

AShukla-GSA left a comment

Choose a reason for hiding this comment

Uh oh!

amirbey Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amirbey Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amirbey Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amirbey left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amirbey left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

amirbey Nov 21, 2024 •

edited

Loading

amirbey Nov 26, 2024 •

edited

Loading

amirbey Nov 26, 2024 •

edited

Loading