Conversation
changelog: Internal, Dependencies, Update dependencies to latest version
Avoid deprecation warnings: "Inheriting from `RuboCop::Cop::Cop` is deprecated. Use `RuboCop::Cop::Base` instead."
mitchellhenke
approved these changes
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates Rubocop and related dependencies to latest versions, resolving outstanding issues and enabling some of the newly-available cops.
Not all newly-available cops were enabled. I used some personal judgment based on severity, existing problems, and style to make a best judgment, but others' opinions are welcome.
Changelogs:
rubocoprubocop-performancerubocop-railsrubocop-rspecPart of the motivation here is to bring in my own upstream patch rubocop/rubocop#13431 to address the false negative now fixed in
app/jobs/account_creation_threat_metrix_job.rb.📜 Testing Plan
Verify build passes.