LG-14189: A/B test for allowing F/T setup and authentication on desktop#11347
Merged
LG-14189: A/B test for allowing F/T setup and authentication on desktop#11347
Conversation
jmdembe
force-pushed
the
jd-LG-14189-ft-setup-desktop
branch
from
cdba74a to
6e5027e
Compare
jmdembe
force-pushed
the
jd-LG-14189-ft-setup-desktop
branch
from
6e5027e to
8adbf86
Compare
Contributor
|
can you rebase this branch to pick up changes to the reviewapp deploy process? |
aduth
reviewed
Oct 22, 2024
kevinsmaster5
approved these changes
Nov 25, 2024
Contributor
kevinsmaster5
left a comment
kevinsmaster5
left a comment
There was a problem hiding this comment.
Looks good. Tested locally with prescribed conditions and behaves as expected.
aduth
reviewed
Nov 25, 2024
app/controllers/users/two_factor_authentication_setup_controller.rb
Outdated
Show resolved
Hide resolved
aduth
reviewed
Nov 25, 2024
…er.rb Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
aduth
approved these changes
Nov 26, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Couple minor suggestions, but works well in my testing otherwise 👍
jmdembe
force-pushed
the
jd-LG-14189-ft-setup-desktop
branch
from
39d3868 to
bac7f21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-14189-Implement: A/B test for allowing F/T setup and authentication on desktop
🛠 Summary of changes
This PR implements an A/B test for setting up F/T unlock on desktops. This test will only run for users who are signing up for authentication methods in English.
📜 Testing Plan
Prerequisites:
In
application.yml, setdesktop_ft_unlock_setup_option_percent_testedconfig value to100in developmentOptional: set
show_unsupported_passkey_platform_authentication_setupto true. This will make it so that when testing by switching to another language, the option does not appear at all.Once on http://localhost:3000, register for a new account
Follow steps to create a new account
Once on the authentication methods setup page, if you set desktop_ft_unlock_setup_option_percent_tested to 100, you will see the F/T unlock setup option
Switch to all other languages, you should not be able to see the setup option
Notes:
desktop_ft_unlock_setup_option_percent_testedto 0 andshow_unsupported_passkey_platform_authentication_setupto false. When following the testing instructions, you will not see the option at all.show_unsupported_passkey_platform_authentication_setupis set totruewhile testing, you will see the F/T unlock option in Spanish, French and Chinese shaded in red. This is not a regression as that config value is set to false in production, so it will not appear as such.