Merged
Conversation
* Add error handling for failed reCAPTCHA execute changelog: Internal, reCAPTCHA, Add error handling for failed reCAPTCHA execute * Improve line breaks for arrange, act, assert * Improve line breaks for arrange, act, assert
* No dependencies so it can run sooner * Point to where the artifact report lives on the security tab Ported from https://gitlab.login.gov/lg/identity-dashboard/-/merge_requests/130 [skip changelog]
changelog: Internal, Identity Proofing, Send state ID type to AAMVA
* changelog: Upcoming Features, Email Selection feature, Add new message for email confirmation * update spec to set value to false * update edit confirmation emails so it only shows proper message * fix rubocop * fix to show when user also signs in after confirming email * add spec for accounts controller flash logic, clean up emails confirmation logic * use hidden field instead of user session * add user mailer spec for additional attribute * move back to using session, but also ensure we delete session after submission * update rubocop and to work for the resend or add different email * fix verify html spec
* Include FormResponse error details for reCAPTCHA at sign-in changelog: Internal, Analytics, Include FormResponse error details for reCAPTCHA at sign-in * Fix user_id described as UUID, not database ID * Fix grammAr for new_device description
* remove is_pilot from implementation * increment up @18F/identity-address-search version to reflect change in interface * Changelog: Internal, In-person proofing, update address search interface to remove obsolete is_pilot field
* update s3 bucket name * changelog: Internal, Reporting, S3 Bucket Name change
* Include missing bg-secondary class to make HR be red * Include in the footer HR as well changelog: User-Facing Improvements, Automated Reports, Add color class to the recently added HRs
jmdembe
approved these changes
Nov 7, 2024
jmhooper
force-pushed
the
stages/rc-2024-11-07
branch
from
4e8a421 to
cc00194
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal
Upcoming Features