Include missing bg-secondary class to make HR be red#11465
Merged
Jeremy1026 merged 2 commits intomainfrom Nov 7, 2024
Merged
Conversation
aduth
approved these changes
Nov 7, 2024
aduth
suggested changes
Nov 7, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Didn't mean to approve, I'm suspecting additional changes are needed per my review comment.
changelog: User-Facing Improvements, Automated Reports, Add color class to the recently added HRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-14793
🛠 Summary of changes
In the edits to my previous PR for report branding the color for the HR was lost because the new CSS class wasn't applied to the
<hr>in the template. This adds the class to make the horizontal rule be red.👀 Screenshots