Add error handling for failed reCAPTCHA execute#11449
Merged
Conversation
changelog: Internal, reCAPTCHA, Add error handling for failed reCAPTCHA execute
kevinsmaster5
approved these changes
Nov 5, 2024
Contributor
kevinsmaster5
left a comment
There was a problem hiding this comment.
Looks good. Works as expected in local testing.
This was referenced Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Improves the behavior of reCAPTCHA submit buttons to ensure that a misconfigured reCAPTCHA environment does not prevent form submission.
Ideally this should never happen, since we would configure an environment correctly, but this adds additional resilience to handle if it were misconfigured. Prior to these changes, it'd be very hard to tell that there was an issue, because we would not receive events corresponding to the submission.
📜 Testing Plan
Validate that if reCAPTCHA is misconfigured, you're still able to sign in.
Configure reCAPTCHA in a way that uses invalid credentials:
make watch_eventsBefore:
After:
"evaluated_as_valid": trueproperty"captcha_validation_performed": trueand"valid_captcha_result": true👀 Screenshots