Skip to content

LG-14692: Banner message for selected email confirmation#11443

Merged
mdiarra3 merged 11 commits intomainfrom
LG-14692-success-email-banner
Nov 5, 2024
Merged

LG-14692: Banner message for selected email confirmation#11443
mdiarra3 merged 11 commits intomainfrom
LG-14692-success-email-banner

Conversation

@mdiarra3
Copy link
Contributor

@mdiarra3 mdiarra3 commented Nov 1, 2024

🎫 Ticket

Link to the relevant ticket:
LG-14692

🛠 Summary of changes

Update Banner message when confirming email to notify users they can update their email for connected accounts.

📜 Testing Plan

  1. Create Account
  2. Add new email to existing account
  3. verify the new content

👀 Screenshots

Screenshot 2024-11-01 at 10 20 18 AM
Screenshot 2024-11-01 at 10 21 36 AM
Screenshot 2024-11-01 at 10 21 41 AM
Screenshot 2024-11-01 at 10 21 46 AM

@mdiarra3 mdiarra3 requested a review from a team November 1, 2024 14:24
Copy link
Contributor

@vrajmohan vrajmohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kevinsmaster5 kevinsmaster5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@mdiarra3 mdiarra3 requested a review from aduth November 4, 2024 15:27
@mdiarra3 mdiarra3 requested a review from aduth November 4, 2024 18:03
@mdiarra3 mdiarra3 requested a review from aduth November 5, 2024 00:31
@mdiarra3 mdiarra3 requested a review from aduth November 5, 2024 17:08
end

def process_successful_creation
session.delete(:in_select_email_flow)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll probably make it so that the in_select_email_flow detail gets dropped if someone clicks "Resend" or "use a different email address" from the success confirmation screen.

@mdiarra3 mdiarra3 merged commit f15db1e into main Nov 5, 2024
@mdiarra3 mdiarra3 deleted the LG-14692-success-email-banner branch November 5, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants