Include FormResponse error details for reCAPTCHA at sign-in#11456
Merged
Include FormResponse error details for reCAPTCHA at sign-in#11456
Conversation
changelog: Internal, Analytics, Include FormResponse error details for reCAPTCHA at sign-in
kevinsmaster5
approved these changes
Nov 5, 2024
Contributor
kevinsmaster5
left a comment
There was a problem hiding this comment.
Looks good, local test behaves as expected in PR description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates sign-in analytics properties to include properties from
SignInRecaptchaForm#to_h, notablyerror_details.Why?
FormResponsesuccess and error details📜 Testing Plan
Verify that if reCAPTCHA form validation fails for a reason other than a failing score (e.g. absent token), you are able to observe this in analytics logging.
You can simulate this by preventing the reCAPTCHA script from loading, similar to what's being addressed in #11451. Currently, reCAPTCHA will submit immediately if the user attempts to submit the form before reCAPTCHA has loaded, which will not include the expected reCAPTCHA token.
Configure reCAPTCHA for local development. You can use any credentials, they don't need to be valid.
make watch_eventsevent_properties.error_details.recaptcha_token.blank = true