Deploy RC 405 to Production#11074
Merged
mitchellhenke merged 21 commits intostages/prodfrom Aug 13, 2024
Merged
Conversation
* Fix spec expectation of issue_year logging changelog: Internal, Automated Testing, Fix spec expectation of issue_year logging * Remove aamva ignored column * Revert "Remove aamva ignored column" This reverts commit 5e58c6f. * Ignore Rubocop
Turn on single-snapshot in the idp_prod image build so that the build does not take 30 minutes.
changelog: Internal, Code Quality, Remove lingering code related to IRS reproofing
* changelog: Bug Fixes, Accounts, refactor presenter pending_ conditionals to account for cases of password-reset * added test for pending gpo * add test for pending idv profile * add password-reset based tests to presenter spec * rotate reset to a before do block
* Analytics: Compact event properties changelog: Internal, Analytics, Avoid sending nil values for analytics events * Remove redundant compact from AnalyticsEvents * Remove nil value assertions for have_logged_event * Recreate compact behavior in FakeAnaytics * Remove nil analytics properties in memoized variables * Handle compacted value exclusion on shared examples * Remove sneaky nil values behind anything / variable * Add allowed_extra_analytics for newly-flagged issues * Handle inconsistently nil values * Restore nested nil values for reCAPTCHA result * Fix timestamp platform precision mismatch
* Document all analytics logged through sign_in_spec changelog: Internal, Analytics, Add internal documentation for analytics methods * Remove unused destination analytics property * Make skip_hybrid_handoff nilable Conditionally assigned https://github.com/18F/identity-idp/blob/c02f05010d324b121f5ba7e33e22ea6a39af8c68/app/controllers/concerns/idv/ab_test_analytics_concern.rb#L11-L12 * Make all A/B test analytics properties optional This doesn't seem to apply in the real-world, but specs stub ab_test_args in a way that these properties would not be included Example: https://github.com/18F/identity-idp/blob/c02f05010d324b121f5ba7e33e22ea6a39af8c68/spec/controllers/idv/welcome_controller_spec.rb#L13 * Document hybrid_handoff_phone_used property * Add nil default to properties not consistently passed * Document password_changed * Remove unnecessary allowed_extra_analytics * Remove unnecessary allowed_extra_analytics * Remove unnecessary allowed_extra_analytics * Stub failed PII validation more realistically
changelog: Internal, In-person Proofing, Ensure the USPS schedule enrollment request executes before a profile is created during the in-person proofing flow.
changelog: Internal, Analytics, Use redirect logging controller for Privacy Act links
The `aamva` column was dropped in #11052. This commit follows-up on that by removing it from the `ignored_columns` list on the model. [skip changelog]
changelog: Bug Fixes, Accessibility, Remove confusing and duplicate external link announcement
changelog: Internal, Code Quality, Improve readability of automated test analytics assertions
**Why**: Fixes warning: > warning: abbrev was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add abbrev to your Gemfile or gemspec. Also contact author of highline-2.1.0 to add abbrev into its gemspec. changelog: Internal, Source code, Update dependencies Co-authored-by: Andrew Duthie <aduth@users.noreply.github.com> --------- Co-authored-by: Andrew Duthie <aduth@users.noreply.github.com>
* Update to Ruby 3.3.4 changelog: Internal, Maintenance, Update to Ruby 3.3.4 * update parser
* LG-13869: Update email languages preference copy changelog: Bug Fixes, Accessibility, Improve content for email language preference hint * Remove unused sentence connector string
changelog: Internal, Error Handling, Avoid duplicating ActiveJob's retry machinery It may address https://gitlab.login.gov/lg-people/lg-people-appdev/Melba/backlog-fy24/-/issues/37. This is an attempt to use ActiveJob's retry machinery properly, so that errors do not bubble up to NewRelic. It also moves some of the test code to using the `test` queue adapter.
* LG-12819/team-judy-metrics * update query * suggested updates * good catch * changelog: Internal, Suspension Metrics, Add suspension and reinstatement metrics to lg99 report
- AgencyIdentity rows are deleted when users are deleted, but ServiceProviderIdentity rows are not deleted changelog: Internal, Tooling, Update uuid-convert script to handle deleted users
…il (#11068) * New config var for EIPP exp date * Added config var for eipp exp date * Display 7 day exp date if EIPP for enrollments * Use if/else rather than terinary * Added eipp spec for date_date days * Fix linter error * changelog: User-Facing Improvements, Enhanced In-person proofing, Added EIPP Expiration Date for Enrollments
* Improve Image Build Caching changelog: Internal, Continuous Integration, Improve Image Build Caching * remove node modules * remove and ignore yarn cache * remove software-properties-common from main image
mitchellhenke
requested review from
Sgtpluck,
aduth,
gina-yamada,
jmhooper,
kevinsmaster5,
shanechesnutt-ft,
vrajmohan and
zachmargolis
zachmargolis
approved these changes
Aug 13, 2024
Contributor
|
I don't think this branch is in sync with staging? https://github.com/18F/identity-idp/compare/stages/rc-2024-08-13..00ed14e7 |
mitchellhenke
force-pushed
the
stages/rc-2024-08-13
branch
from
9de7ad1 to
00ed14e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal