Remove tests and logging related to IRS reproofing#11055
Merged
Conversation
mitchellhenke
approved these changes
Aug 8, 2024
n1zyy
approved these changes
Aug 8, 2024
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
👏 This is dead code, and the test doesn't assert what it says it does anyway.
app/services/analytics_events.rb
Outdated
Contributor
There was a problem hiding this comment.
This was from back in the Team Agnes Attempts API days. Most of that code has already been ripped out; this one must have escaped notice.
changelog: Internal, Code Quality, Remove lingering code related to IRS reproofing
aduth
force-pushed
the
aduth-irs-reproofing-specs-logging
branch
from
ef36b1b to
2c5b96c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates a test case and logging property to remove stale references to IRS reproofing.
While "reproofing" still exists, these appear to be targeted specifically at the IRS-initiated reproofing, which no longer exists in the code.
The specs were added in #7859, and assertions targeting expected IRS attempts API logging have since been removed, making the tests largely ineffective at testing anything meaningful.
This also removes one of the few skipped tests in the codebase (see related Slack discussion).
📜 Testing Plan
Verify that build passes.