Skip to content

LG-14153 Display EIPP Expiration Date on Ready to Verify View and Email#11068

Merged
gina-yamada merged 8 commits intomainfrom
yamada/lg-14153-update-eipp-exp-date
Aug 13, 2024
Merged

LG-14153 Display EIPP Expiration Date on Ready to Verify View and Email#11068
gina-yamada merged 8 commits intomainfrom
yamada/lg-14153-update-eipp-exp-date

Conversation

@gina-yamada
Copy link
Contributor

@gina-yamada gina-yamada commented Aug 12, 2024

🚨TO DO: Add in_person_eipp_enrollment_validity_in_days and set to integer 7 in before this gets merged🚨
Here is my plan

  • joy Did not update in JOY. JOY is down. We will handle this when we fix the JOY env
  • dev
  • int
  • staging
  • prod

🎫 Ticket

LG-14153 Update EIPP barcode expiration in ready to verify page/email

🛠 Summary of changes

  • Created new config var in_person_eipp_enrollment_validity_in_days as an integer
  • If Enhanced In-person Enrollment, use new config var as days to expire for EIPP enrollments, else default to IdentityConfig.store.in_person_enrollment_validity_in_days.days
  • New spec to test for EIPP Enrollment

📜 Testing Plan

  1. Confirm existing behavior is not affected
  1. Confirm new behavior is working as expected

👀 Screenshots

IPP Enrollment

Screenshot 2024-08-12 at 11 14 25 AM

Screenshot 2024-08-12 at 11 17 02 AM

Screenshot 2024-08-12 at 11 19 27 AM

Screenshot 2024-08-12 at 11 24 43 AM

EIPP Enrollment

Screenshot 2024-08-12 at 11 32 27 AM

Screenshot 2024-08-12 at 11 32 52 AM

Screenshot 2024-08-12 at 11 33 13 AM

Screenshot 2024-08-12 at 11 33 50 AM

@gina-yamada gina-yamada changed the title WIP LG-14153 Display EIPP Expiration Date on Ready to Verify View and Email LG-14153 Display EIPP Expiration Date on Ready to Verify View and Email Aug 12, 2024
@gina-yamada gina-yamada requested review from a team, KeithNava, WheresHJ and aduth August 12, 2024 17:48
Copy link

@WheresHJ WheresHJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamBirdsall
Copy link
Contributor

Screenshot 2024-08-12 at 4 21 09 PM

Ran through the test steps and the date of the 11th (30 days) is shown in all places correctly, but the message above on the reminder mentions 28 days. Assuming that that is because the reminder is sent a couple days after initial enrollment is created?

@WilliamBirdsall
Copy link
Contributor

WilliamBirdsall commented Aug 12, 2024

EIPP flow looks mostly good except when I navigate to the specified mailer I think im seeing the IPP testing email instead. I even tried using a private window and same thing...

@gina-yamada
Copy link
Contributor Author

EIPP flow looks mostly good except when I navigate to the specified mailer I think im seeing the IPP testing email instead. I even tried using a private window and same thing...

You can visit: http://localhost:3000/rails/mailers/user_mailer/ and there is a list of all of the emails templates. You do not need to create an enrollment before going here. These templates are using variables from spec/mailers/previews/user_mailer_preview.rb so do not represent the actual value if you created an enrollment today.

Copy link
Contributor

@WilliamBirdsall WilliamBirdsall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and ran through test steps successfully

@gina-yamada gina-yamada merged commit 8ffeb31 into main Aug 13, 2024
@gina-yamada gina-yamada deleted the yamada/lg-14153-update-eipp-exp-date branch August 13, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants